Bastian Blank
2010-Feb-24 13:58 UTC
[Xen-devel] [PATCH] xen: fbdev frontend needs xenbus frontend
The fbdev (and kbddev) frontend needs the xenbus frontend, but does not define a dependency. Make the fbdev frontend select the xenbus frontend. Signed-off-by: Bastian Blank <waldi@debian.org> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 188e1ba..efac9e3 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND select FB_SYS_IMAGEBLIT select FB_SYS_FOPS select FB_DEFERRED_IO + select XEN_XENBUS_FRONTEND default y help This driver implements the front-end of the Xen virtual -- No more blah, blah, blah! -- Kirk, "Miri", stardate 2713.6 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2010-Feb-25 12:40 UTC
Re: [Xen-devel] [PATCH] xen: fbdev frontend needs xenbus frontend
On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote:> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not > define a dependency. Make the fbdev frontend select the xenbus > frontend.Isn''t this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so (and if the above mention commit isn''t in xen/next) shouldn''t you also make this change for drives/input/Kconfig for XEN_KBDDEV_FRONTEND?> > Signed-off-by: Bastian Blank <waldi@debian.org> > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 188e1ba..efac9e3 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND > select FB_SYS_IMAGEBLIT > select FB_SYS_FOPS > select FB_DEFERRED_IO > + select XEN_XENBUS_FRONTEND > default y > help > This driver implements the front-end of the Xen virtual > -- > No more blah, blah, blah! > -- Kirk, "Miri", stardate 2713.6 > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2010-Feb-25 17:37 UTC
Re: [Xen-devel] [PATCH] xen: fbdev frontend needs xenbus frontend
On 02/25/2010 04:40 AM, Konrad Rzeszutek Wilk wrote:> On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote: > >> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not >> define a dependency. Make the fbdev frontend select the xenbus >> frontend. >> > Isn''t this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so > (and if the above mention commit isn''t in xen/next) > shouldn''t you also make this change for drives/input/Kconfig for > XEN_KBDDEV_FRONTEND? >Did that end up in .33? Should we put it in -stable too? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk
2010-Feb-25 17:48 UTC
Re: [Xen-devel] [PATCH] xen: fbdev frontend needs xenbus frontend
On Thu, Feb 25, 2010 at 09:37:38AM -0800, Jeremy Fitzhardinge wrote:> On 02/25/2010 04:40 AM, Konrad Rzeszutek Wilk wrote: >> On Wed, Feb 24, 2010 at 02:58:28PM +0100, Bastian Blank wrote: >> >>> The fbdev (and kbddev) frontend needs the xenbus frontend, but does not >>> define a dependency. Make the fbdev frontend select the xenbus >>> frontend. >>> >> Isn''t this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so >> (and if the above mention commit isn''t in xen/next) >> shouldn''t you also make this change for drives/input/Kconfig for >> XEN_KBDDEV_FRONTEND? >> > > Did that end up in .33? Should we put it in -stable too?I took a look at the code and I think Bastian''s is OK. The -stable has this: 152 config XEN_KBDDEV_FRONTEND 153 tristate "Xen virtual keyboard and mouse support" 154 depends on XEN_FBDEV_FRONTEND 155 default y So it would end up selecting the xenbus frontend as well with Bastian''s patch. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel