To support 1GB host page, this patch changes the MMIO starting address to 1GB boundary. Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Wei Huang <wei.huang2@amd.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Feb-23 07:56 UTC
[Xen-devel] Re: [PATCH][1/4] Enable 1GB for Xen HVM host page
What''s the performance gain from 1GB mappings in HAP tables like? What about just the (possible) extra 1GB mapping from this particular patch? Is it worth making guest-visible efforts like this (admittedly small) one? After all, the probably most frequently accessed 1GB starting at address 0x0 cannot be done with a 1GB mapping and we live with it. -- Keir On 22/02/2010 17:17, "Wei Huang" <wei.huang2@amd.com> wrote:> To support 1GB host page, this patch changes the MMIO starting address > to 1GB boundary. > > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> > Signed-off-by: Wei Huang <wei.huang2@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Huang2, Wei
2010-Feb-23 15:03 UTC
[Xen-devel] RE: [PATCH][1/4] Enable 1GB for Xen HVM host page
The performance gain depends on applications. We have seen 5% performance improvement for certain benchmarks. But some have no perf. gains over 2MB (no performance degradation either). That is why I add an option to turn it off in case people don''t want 1GB. I didn''t have access to my guest QEMU until applying this patch from Dongxiao. Dongxiao might have other comments. -Wei -----Original Message----- From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: Tuesday, February 23, 2010 1:57 AM To: Huang2, Wei; ''xen-devel@lists.xensource.com''; Xu, Dongxiao Subject: Re: [PATCH][1/4] Enable 1GB for Xen HVM host page What''s the performance gain from 1GB mappings in HAP tables like? What about just the (possible) extra 1GB mapping from this particular patch? Is it worth making guest-visible efforts like this (admittedly small) one? After all, the probably most frequently accessed 1GB starting at address 0x0 cannot be done with a 1GB mapping and we live with it. -- Keir On 22/02/2010 17:17, "Wei Huang" <wei.huang2@amd.com> wrote:> To support 1GB host page, this patch changes the MMIO starting address > to 1GB boundary. > > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> > Signed-off-by: Wei Huang <wei.huang2@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-Feb-24 04:25 UTC
[Xen-devel] RE: [PATCH][1/4] Enable 1GB for Xen HVM host page
Huang2, Wei wrote:> The performance gain depends on applications. We have seen 5% > performance improvement for certain benchmarks. But some have no > perf. gains over 2MB (no performance degradation either). That is why > I add an option to turn it off in case people don''t want 1GB. > > I didn''t have access to my guest QEMU until applying this patch from > Dongxiao. Dongxiao might have other comments.When allocating guest memory without the patch, Xend will treat 3G-4G as normal memory, ignoring the 3.75-4G MMIO hole. This patch modifies MMIO start address to be 1GB aligned and could fix the issue. Indeed, this patch may have some influence to pure 32bit guest, changing its max memory from 3.75G to 3G. Anyway, we can change it to alloc 2M pages between 3G and 4G if you think this particular patch is improper. Thanks! Dongxiao> > -Wei > > -----Original Message----- > From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] > Sent: Tuesday, February 23, 2010 1:57 AM > To: Huang2, Wei; ''xen-devel@lists.xensource.com''; Xu, Dongxiao > Subject: Re: [PATCH][1/4] Enable 1GB for Xen HVM host page > > What''s the performance gain from 1GB mappings in HAP tables like? > What about > just the (possible) extra 1GB mapping from this particular patch? Is > it > worth making guest-visible efforts like this (admittedly small) one? > After > all, the probably most frequently accessed 1GB starting at address 0x0 > cannot be done with a 1GB mapping and we live with it. > > -- Keir > > On 22/02/2010 17:17, "Wei Huang" <wei.huang2@amd.com> wrote: > >> To support 1GB host page, this patch changes the MMIO starting >> address to 1GB boundary. >> >> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> >> Signed-off-by: Wei Huang <wei.huang2@amd.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Feb-24 09:12 UTC
[Xen-devel] Re: [PATCH][1/4] Enable 1GB for Xen HVM host page
On 24/02/2010 04:25, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote:> When allocating guest memory without the patch, Xend will treat 3G-4G > as normal memory, ignoring the 3.75-4G MMIO hole. This patch modifies > MMIO start address to be 1GB aligned and could fix the issue. > > Indeed, this patch may have some influence to pure 32bit guest, > changing its max memory from 3.75G to 3G. > > Anyway, we can change it to alloc 2M pages between 3G and 4G if you > think this particular patch is improper.I would expect it to fall back to 2MB extents, and from there back to 4kB extents as necessary, for any range where: (a) the range to be allocated for is not 1GB-sized and -aligned; or (b) no 1GB extents are available from Xen''s free pool. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel