Masaki Kanno
2010-Feb-18 02:52 UTC
[Xen-devel] [PATCH][RFC] Fix value set for uname of phantom tap devices
Hi, cfg_xenapi[''image''] is always set to dev_info[''uname''] even if cfg_xenapi[''image''] does not include ''tap:''. I''m not sure about phantom tap devices. However, I think that the following patch is correct. How do you think? diff -r b4041e7bbe1b tools/python/xen/xend/XendConfig.py --- a/tools/python/xen/xend/XendConfig.py Wed Feb 17 12:11:13 2010 +0000 +++ b/tools/python/xen/xend/XendConfig.py Thu Feb 18 11:35:30 2010 +0900 @@ -1686,8 +1686,9 @@ elif dev_type == ''tap'': if cfg_xenapi.get(''image'').find(''tap:'') == -1: dev_info[''uname''] = ''tap:qcow:%s'' % cfg_xenapi.get(''image'') + else: + dev_info[''uname''] = cfg_xenapi.get(''image'') dev_info[''dev''] = ''/dev/%s'' % cfg_xenapi.get(''device'') - dev_info[''uname''] = cfg_xenapi.get(''image'') dev_info[''mode''] = cfg_xenapi.get(''mode'') dev_info[''backend''] = ''0'' dev_uuid = cfg_xenapi.get(''uuid'', uuid.createString()) Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel