Liu, Jinsong
2010-Feb-11 17:40 UTC
[Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug Win2000 will BSOD if cpus > 15, in order to compatible support win2000 HVM, this patch change HVM_MAX_VCPUS to 15. This patch also fix a small bug related to HVM_MAX_VCPUS. Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2010-Feb-11 17:59 UTC
Re: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
On Thursday 11 February 2010 18:40:58 Liu, Jinsong wrote:> Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug > > Win2000 will BSOD if cpus > 15, in order to compatible support win2000 HVM, > this patch change HVM_MAX_VCPUS to 15. This patch also fix a small bug > related to HVM_MAX_VCPUS. > > Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>This patch makes no sense to me. Didn''t win2000 crash before the number of HVM_MAX_VCPUS has been increased from 32 to 128 ? Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Feb-11 18:27 UTC
[Xen-devel] Re: [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
On 11/02/2010 17:40, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug > > Win2000 will BSOD if cpus > 15, in order to compatible support win2000 HVM, > this patch change HVM_MAX_VCPUS to 15. > This patch also fix a small bug related to HVM_MAX_VCPUS.Yeah, it''s not really on to limit HVM #vcpus for all time, to deal with one legacy OS. We''ll have to build a legacy DSDT to deploy when hvm_info->nr_vcpus<=15. I guess I can look into that, and also I''m going to stop checking in the pre-built dsdt.c file. It''s now really big and constantly changing, and people who build the Xen tree are just going to have to sort out to have iasl installed. In fact the Makefile already grabs it automatically... -- Keir> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Feb-11 22:48 UTC
Re: [Xen-devel] Re: [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
On 11/02/2010 18:27, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:> Yeah, it''s not really on to limit HVM #vcpus for all time, to deal with one > legacy OS. We''ll have to build a legacy DSDT to deploy when > hvm_info->nr_vcpus<=15. > > I guess I can look into that, and also I''m going to stop checking in the > pre-built dsdt.c file.See xen-unstable:20933, which should give best of both worlds (working W2K for up to 15 processors; other OSes can continue to have up to HVM_MAX_VCPUS processors). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jiang, Yunhong
2010-Feb-12 01:51 UTC
RE: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
I think this is more about a regression. Originally hvmloader only create 14 Processor definition in dsdt and the HVM_MAX_VCPUS is not used in that code.Later, when the vCPU hotplug added, that 14 is changed to HVM_MAX_VCPUS and cause regression. Thanks --jyh>-----Original Message----- >From: Christoph Egger [mailto:Christoph.Egger@amd.com] >Sent: Friday, February 12, 2010 2:00 AM >To: xen-devel@lists.xensource.com >Cc: Liu, Jinsong; Jiang, Yunhong; Keir Fraser >Subject: Re: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, >and fix a small bug > >On Thursday 11 February 2010 18:40:58 Liu, Jinsong wrote: >> Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug >> >> Win2000 will BSOD if cpus > 15, in order to compatible support win2000 HVM, >> this patch change HVM_MAX_VCPUS to 15. This patch also fix a small bug >> related to HVM_MAX_VCPUS. >> >> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> > >This patch makes no sense to me. >Didn''t win2000 crash before the number of HVM_MAX_VCPUS >has been increased from 32 to 128 ? > >Christoph > > >-- >---to satisfy European Law for business letters: >Advanced Micro Devices GmbH >Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen >Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni >Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen >Registergericht Muenchen, HRB Nr. 43632_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2010-Feb-12 08:05 UTC
Re: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug
Ah, I see. Thanks for clarification. Christoph On Friday 12 February 2010 02:51:03 Jiang, Yunhong wrote:> I think this is more about a regression. Originally hvmloader only create > 14 Processor definition in dsdt and the HVM_MAX_VCPUS is not used in that > code.Later, when the vCPU hotplug added, that 14 is changed to > HVM_MAX_VCPUS and cause regression. > > Thanks > --jyh > > >-----Original Message----- > >From: Christoph Egger [mailto:Christoph.Egger@amd.com] > >Sent: Friday, February 12, 2010 2:00 AM > >To: xen-devel@lists.xensource.com > >Cc: Liu, Jinsong; Jiang, Yunhong; Keir Fraser > >Subject: Re: [Xen-devel] [PATCH 2/2] Vcpu hotplug: change HVM_MAX_VCPUS to > > 15, and fix a small bug > > > >On Thursday 11 February 2010 18:40:58 Liu, Jinsong wrote: > >> Vcpu hotplug: change HVM_MAX_VCPUS to 15, and fix a small bug > >> > >> Win2000 will BSOD if cpus > 15, in order to compatible support win2000 > >> HVM, this patch change HVM_MAX_VCPUS to 15. This patch also fix a small > >> bug related to HVM_MAX_VCPUS. > >> > >> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com> > > > >This patch makes no sense to me. > >Didn''t win2000 crash before the number of HVM_MAX_VCPUS > >has been increased from 32 to 128 ? > > > >Christoph > > > > > >-- > >---to satisfy European Law for business letters: > >Advanced Micro Devices GmbH > >Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen > >Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni > >Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen > >Registergericht Muenchen, HRB Nr. 43632-- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel