Hi! Build fails on Linux when no ebtables are installed: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function ‘ebt_target_imq’: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13: error: ‘struct sk_buff’ has no member named ‘imq_flags’ Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 05/02/2010 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi! > > Build fails on Linux when no ebtables are installed: > > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function ebt_target_imq¹: > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13: error: struct sk_buff¹ > has no member named imq_flags¹Brendan, can you send a fix? Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday 05 February 2010 18:08:20 Keir Fraser wrote:> On 05/02/2010 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi! > > > > Build fails on Linux when no ebtables are installed: > > > > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function > > ebt_target_imq¹: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13: > > error: struct sk_buff¹ has no member named imq_flags¹ > > Brendan, can you send a fix?I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is ''N'' by default. IMO, you should either document this new requirement or enable/disable this via autodetection. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi friends Please Christoph... Do not forget send feedback about remus to us... I need Fault Tolerance on my VM too and I will appreciate any tricks... Thanks Em Sex, 2010-02-05 às 18:12 +0100, Christoph Egger escreveu:> On Friday 05 February 2010 18:08:20 Keir Fraser wrote: > > On 05/02/2010 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > > Hi! > > > > > > Build fails on Linux when no ebtables are installed: > > > > > > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function > > > ebt_target_imq¹: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13: > > > error: struct sk_buff¹ has no member named imq_flags¹ > > > > Brendan, can you send a fix? > > I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is ''N'' > by default. IMO, you should either document this new requirement or > enable/disable this via autodetection. > > ChristophGilberto Nunes Ferreira Suporte T.I. Selbetti Gestão de Documentos (47) 3441-6004 / (47) 8861-6672 Fax (47) 3441-6027 gilberto.nunes@selbetti.com.br _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Friday, 05 February 2010 at 18:12, Christoph Egger wrote:> On Friday 05 February 2010 18:08:20 Keir Fraser wrote: > > On 05/02/2010 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > > Hi! > > > > > > Build fails on Linux when no ebtables are installed: > > > > > > /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c: In function > > > ebt_target_imq¹: /xen/xen-unstable.hg/tools/remus/kmod/ebt_imq.c:13: > > > error: struct sk_buff¹ has no member named imq_flags¹ > > > > Brendan, can you send a fix? > > I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is ''N'' > by default. IMO, you should either document this new requirement or > enable/disable this via autodetection.Sorry, I was out of the country for a few days. It looks like Keir has already made the module not build if IMQ is off. I''ve attached a (untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for Linux xen/xen0. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 09/02/2010 19:04, "Brendan Cully" <brendan@cs.ubc.ca> wrote:>> I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is ''N'' >> by default. IMO, you should either document this new requirement or >> enable/disable this via autodetection. > > Sorry, I was out of the country for a few days. It looks like Keir has > already made the module not build if IMQ is off. I''ve attached a > (untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for > Linux xen/xen0.No hunks of that patch applied at all, to xen-unstable tip. Weird. Try again. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wednesday, 10 February 2010 at 09:23, Keir Fraser wrote:> On 09/02/2010 19:04, "Brendan Cully" <brendan@cs.ubc.ca> wrote: > > >> I found a workaround: Enable CONFIG_IMQ in the dom0 kernel config. It is ''N'' > >> by default. IMO, you should either document this new requirement or > >> enable/disable this via autodetection. > > > > Sorry, I was out of the country for a few days. It looks like Keir has > > already made the module not build if IMQ is off. I''ve attached a > > (untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for > > Linux xen/xen0. > > No hunks of that patch applied at all, to xen-unstable tip. Weird. Try > again. :-)It was against linux-2.6.18-xen, not xen-unstable. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 10/02/2010 16:21, "Brendan Cully" <brendan@cs.ubc.ca> wrote:>>> Sorry, I was out of the country for a few days. It looks like Keir has >>> already made the module not build if IMQ is off. I''ve attached a >>> (untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for >>> Linux xen/xen0. >> >> No hunks of that patch applied at all, to xen-unstable tip. Weird. Try >> again. :-) > > It was against linux-2.6.18-xen, not xen-unstable.Argh. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wednesday, 10 February 2010 at 16:31, Keir Fraser wrote:> On 10/02/2010 16:21, "Brendan Cully" <brendan@cs.ubc.ca> wrote: > > >>> Sorry, I was out of the country for a few days. It looks like Keir has > >>> already made the module not build if IMQ is off. I''ve attached a > >>> (untested) patch to linux-2.6.18-xen.hg to turn on IMQ by default for > >>> Linux xen/xen0. > >> > >> No hunks of that patch applied at all, to xen-unstable tip. Weird. Try > >> again. :-) > > > > It was against linux-2.6.18-xen, not xen-unstable. > > Argh.Does that mean you''d prefer a patch to buildconfigs/enable-xen-config in xen-unstable? It wasn''t clear to me which was better. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 11/02/2010 20:13, "Brendan Cully" <brendan@cs.ubc.ca> wrote:>>>> No hunks of that patch applied at all, to xen-unstable tip. Weird. Try >>>> again. :-) >>> >>> It was against linux-2.6.18-xen, not xen-unstable. >> >> Argh. > > Does that mean you''d prefer a patch to buildconfigs/enable-xen-config > in xen-unstable? It wasn''t clear to me which was better.It means I totally missed that the patch applied to the Linux repo, even though your original email stated it. I did expect a patch to enable-xen-config, but I don''t much mind either way. I applied your original patch now, anyway. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel