Kamala Narasimhan
2010-Jan-28 19:30 UTC
[xen-devel][PATCH] Update guest rtc upon resume from S3
Upon resuming a guest after a host S3 resume, guest time is incorrect. Attached patch should fix that issue. Signed-off-by: Kamala Narasimhan <kamala.narasimhan@citrix.com> Kamala _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Jan-29 07:22 UTC
Re: [xen-devel][PATCH] Update guest rtc upon resume from S3
This is a host S3 issue rather than a guest S3 issue, isn''t it? By which I mean, guest RTCs are not kept up to date across host S3 (obviously), but they are kept up to date all the while the host is actually running (even if a guest is in virtual S3 state). So perhaps this properly belongs in the host S3 resume path. What do you think? -- Keir On 28/01/2010 19:30, "Kamala Narasimhan" <Kamala.Narasimhan@citrix.com> wrote:> Upon resuming a guest after a host S3 resume, guest time is incorrect. > Attached patch should fix that issue. > > Signed-off-by: Kamala Narasimhan <kamala.narasimhan@citrix.com> > > Kamala_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kamala Narasimhan
2010-Jan-29 09:30 UTC
RE: [xen-devel][PATCH] Update guest rtc upon resume from S3
Yes, I have observed this only after host S3 resume. I have attached a revised patch that is invoked during host resume. Please consider this or tweak it as necessary. Signed-off-by: Kamala Narasimhan <kamala.narasimhan@citrix.com> Kamala> -----Original Message----- > From: Keir Fraser > Sent: Friday, January 29, 2010 2:23 AM > To: Kamala Narasimhan; xen-devel@lists.xensource.com > Subject: Re: [xen-devel][PATCH] Update guest rtc upon resume from S3 > > This is a host S3 issue rather than a guest S3 issue, isn''t it? By > which I > mean, guest RTCs are not kept up to date across host S3 (obviously), > but > they are kept up to date all the while the host is actually running > (even if > a guest is in virtual S3 state). > > So perhaps this properly belongs in the host S3 resume path. What do > you > think? > > -- Keir > > On 28/01/2010 19:30, "Kamala Narasimhan" <Kamala.Narasimhan@citrix.com> > wrote: > > > Upon resuming a guest after a host S3 resume, guest time is incorrect. > > Attached patch should fix that issue. > > > > Signed-off-by: Kamala Narasimhan <kamala.narasimhan@citrix.com> > > > > Kamala >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel