Xu, Dongxiao
2010-Jan-20 05:11 UTC
[Xen-devel][PATCH] Change vcpu_avail type to hex string when passing to xc.hvm_build()
Change vcpu_avail to hex string when passing to xc.hvm_build() - vcpu_avail is the bitmap to present the online vcpus in guest. vcpu online/offline patchset defines its type as uint64_t, so it could maxium support 64 vcpus. When passing parameters to hvm_build(), change its type to str to support more vcpus per VM (ex. 128 vcpus). Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Jan-20 09:35 UTC
Re: [Xen-devel][PATCH] Change vcpu_avail type to hex string when passing to xc.hvm_build()
On 20/01/2010 05:11, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote:> Change vcpu_avail to hex string when passing to xc.hvm_build() > - vcpu_avail is the bitmap to present the online vcpus in guest. > vcpu online/offline patchset defines its type as uint64_t, so it > could maxium support 64 vcpus. When passing parameters to hvm_build(), > change its type to str to support more vcpus per VM (ex. 128 vcpus). > > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>Ugly. Try out c/s 20825 instead. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-Jan-20 11:27 UTC
RE: [Xen-devel][PATCH] Change vcpu_avail type to hex string when passing to xc.hvm_build()
Hi Keir, I''m sorry I am not familiar with C/Python inter-programming... Actually I have thought of this patch for a looong time on how to make it clean... But it seems that system doesn''t work correctly. I assigned 10 vcpus for guest, however after guest boots, it only has 8 vcpus. However it is correct if I assign 128 vcpus. Thanks! Dongxiao Keir Fraser wrote:> On 20/01/2010 05:11, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote: > >> Change vcpu_avail to hex string when passing to xc.hvm_build() >> - vcpu_avail is the bitmap to present the online vcpus in guest. >> vcpu online/offline patchset defines its type as uint64_t, so it >> could maxium support 64 vcpus. When passing parameters to >> hvm_build(), change its type to str to support more vcpus per VM >> (ex. 128 vcpus). >> >> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> > > Ugly. Try out c/s 20825 instead. > > -- Keir_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Xu, Dongxiao
2010-Jan-20 11:32 UTC
RE: [Xen-devel][PATCH] Change vcpu_avail type to hex string when passing to xc.hvm_build()
Oh, 20826 fixes it. Thanks -- Dongxiao Xu, Dongxiao wrote:> Hi Keir, > I''m sorry I am not familiar with C/Python inter-programming... > Actually I have thought of this patch for a looong time on how to > make it clean... > But it seems that system doesn''t work correctly. I assigned 10 vcpus > for guest, however after guest boots, it only has 8 vcpus. However it > is correct if I assign 128 vcpus. > > Thanks! > Dongxiao > > Keir Fraser wrote: >> On 20/01/2010 05:11, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote: >> >>> Change vcpu_avail to hex string when passing to xc.hvm_build() >>> - vcpu_avail is the bitmap to present the online vcpus in guest. >>> vcpu online/offline patchset defines its type as uint64_t, so it >>> could maxium support 64 vcpus. When passing parameters to >>> hvm_build(), change its type to str to support more vcpus per VM >>> (ex. 128 vcpus). >>> >>> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> >> >> Ugly. Try out c/s 20825 instead. >> >> -- Keir > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensou_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2010-Jan-20 12:20 UTC
Re: [Xen-devel][PATCH] Change vcpu_avail type to hex string when passing to xc.hvm_build()
On 20/01/2010 11:27, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote:> Hi Keir, > I''m sorry I am not familiar with C/Python inter-programming... > Actually I have thought of this patch for a looong time on how to make it > clean...I''m no expert either. Since the conversion function names have a pattern, I grepped the Python-2.3 sources for PyLong_As to see what sort of things were available. There''s a lot more than is documented. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel