Stefano Stabellini
2010-Jan-18 16:54 UTC
[Xen-devel] [PATCH] xc_domain_save: allocate pfn_err before use
Hi all,
due to recent changes related to xc_map_foreign_bulk, xc_domain_save
segfaults because it tries to use pfn_err without allocating it first.
This patch fixes it.
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
diff -r 618b3597603c tools/libxc/xc_domain_save.c
--- a/tools/libxc/xc_domain_save.c Mon Jan 18 10:37:28 2010 +0000
+++ b/tools/libxc/xc_domain_save.c Mon Jan 18 16:46:36 2010 +0000
@@ -1273,6 +1273,7 @@
if ( batch == 0 )
goto skip; /* vanishingly unlikely... */
+ pfn_err = realloc(pfn_err, sizeof(int) * batch);
region_base = xc_map_foreign_bulk(
xc_handle, dom, PROT_READ, pfn_type, pfn_err, batch);
if ( region_base == NULL )
@@ -1832,6 +1833,7 @@
free(pfn_type);
free(pfn_batch);
+ free(pfn_err);
free(to_send);
free(to_fix);
free(to_skip);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel