Boris Derzhavets
2009-May-21 08:09 UTC
Re: [Xen-devel] [PATCH] privcmd: MMAPBATCH: Fix error handling/reporting
I''ve compiled 2.6.30-rc6-tip with xenfs built-in and successfully created and ran Ubuntu 8.10 Server HVM and CentOS 5.3 HVM DomUs with traditional hvm-profiles. Remote VNC connections to HVM DomUs might be unexpectedly frozen either broken after 5-10 minutes . Boris. --- On Wed, 5/20/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote: From: Jeremy Fitzhardinge <jeremy@goop.org> Subject: Re: [Xen-devel] [PATCH] privcmd: MMAPBATCH: Fix error handling/reporting To: "Ian Campbell" <ian.campbell@citrix.com> Cc: xen-devel@lists.xensource.com Date: Wednesday, May 20, 2009, 5:13 PM Ian Campbell wrote:> On error IOCTL_PRIVCMD_MMAPBATCH is expected to set the top nibble of > the effected MFN and return 0. Currently it leaves the MFN unmodified > and returns the number of failures. Therefore: > > - reimplement remap_domain_mfn_range() using direct > HYPERVISOR_mmu_update() calls and small batches. The xen_set_domain_pte() > interface does not report errors and since some failures are > expected/normal using the multicall infrastructure is too noisy. > - return 0 as expected > - writeback the updated MFN list to mmapbatch->arr not over mmapbatch, > smashing the caller''s stack. > - remap_domain_mfn_range can be static. > > With this change I am able to start an HVM domain. >This breaks compiling xenfs as a module; neither flush_tlb_all or arbitrary_virt_to_machine are exported, I think. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-May-21 17:16 UTC
Re: [Xen-devel] [PATCH] privcmd: MMAPBATCH: Fix error handling/reporting
Boris Derzhavets wrote:> I''ve compiled 2.6.30-rc6-tip with xenfs built-in and successfully > created and ran > Ubuntu 8.10 Server HVM and CentOS 5.3 HVM DomUs with traditional > hvm-profiles. > Remote VNC connections to HVM DomUs might be unexpectedly frozen > either broken after 5-10 minutes . >That''s not new behaviour though, is it? You reported VNC failures before. Does disabling GSO help? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel