Nitin A Kamble
2009-May-06 22:11 UTC
[Xen-devel] [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
Keir,
Just like the apicid, x2apicid is also unique to each cpu. x2apicid is
coming from edx register of the cpuid leaf 0xb.
Please Apply/comment.
Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com>
diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c
--- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700
+++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700
@@ -1687,6 +1687,10 @@
*ebx |= (v->vcpu_id * 2) << 24;
if ( vlapic_hw_disabled(vcpu_vlapic(v)) )
__clear_bit(X86_FEATURE_APIC & 31, edx);
+ } else if ( input == 0x0000000b )
+ {
+ /* fix the x2apicid */
+ *edx = v->vcpu_id * 2;
}
}
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Keir Fraser
2009-May-07 07:05 UTC
[Xen-devel] Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
What''s the point of emulating an x2apicid when we don''t emulate an x2apic? -- Keir On 06/05/2009 23:11, "Nitin A Kamble" <nitin.a.kamble@intel.com> wrote:> Keir, > > Just like the apicid, x2apicid is also unique to each cpu. x2apicid is > coming from edx register of the cpuid leaf 0xb. > > Please Apply/comment. > > Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com> > > > diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c > --- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 > +++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 > @@ -1687,6 +1687,10 @@ > *ebx |= (v->vcpu_id * 2) << 24; > if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) > __clear_bit(X86_FEATURE_APIC & 31, edx); > + } else if ( input == 0x0000000b ) > + { > + /* fix the x2apicid */ > + *edx = v->vcpu_id * 2; > } > } > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kamble, Nitin A
2009-May-07 16:48 UTC
[Xen-devel] RE: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
Keir, It is be used to find out the extended cpu topology of specified in the leaf 0xb. Thanks & Regards, Nitin Linux Open Source Technology Center, Intel Corporation ---------------------------------------------------------------------------- The Mind is like a parachute; it works much better when it''s open.>-----Original Message----- >From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] >Sent: Thursday, May 07, 2009 12:05 AM >To: Kamble, Nitin A >Cc: xen-devel@lists.xensource.com >Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf >0xb > >What''s the point of emulating an x2apicid when we don''t emulate an x2apic? > > -- Keir > >On 06/05/2009 23:11, "Nitin A Kamble" <nitin.a.kamble@intel.com> wrote: > >> Keir, >> >> Just like the apicid, x2apicid is also unique to each cpu. x2apicid is >> coming from edx register of the cpuid leaf 0xb. >> >> Please Apply/comment. >> >> Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com> >> >> >> diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c >> --- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 >> +++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 >> @@ -1687,6 +1687,10 @@ >> *ebx |= (v->vcpu_id * 2) << 24; >> if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) >> __clear_bit(X86_FEATURE_APIC & 31, edx); >> + } else if ( input == 0x0000000b ) >> + { >> + /* fix the x2apicid */ >> + *edx = v->vcpu_id * 2; >> } >> } >> >> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2009-May-07 18:14 UTC
[Xen-devel] Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
Hm, ok, well I think it is a pretty inoffensive patch anyway. I can queue it for post 3.4. - Keir On 07/05/2009 17:48, "Kamble, Nitin A" <nitin.a.kamble@intel.com> wrote:> Keir, > It is be used to find out the extended cpu topology of specified in the > leaf 0xb. > > Thanks & Regards, > Nitin > Linux Open Source Technology Center, Intel Corporation > ---------------------------------------------------------------------------- > The Mind is like a parachute; it works much better when it''s open. > >> -----Original Message----- >> From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] >> Sent: Thursday, May 07, 2009 12:05 AM >> To: Kamble, Nitin A >> Cc: xen-devel@lists.xensource.com >> Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf >> 0xb >> >> What''s the point of emulating an x2apicid when we don''t emulate an x2apic? >> >> -- Keir >> >> On 06/05/2009 23:11, "Nitin A Kamble" <nitin.a.kamble@intel.com> wrote: >> >>> Keir, >>> >>> Just like the apicid, x2apicid is also unique to each cpu. x2apicid is >>> coming from edx register of the cpuid leaf 0xb. >>> >>> Please Apply/comment. >>> >>> Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com> >>> >>> >>> diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c >>> --- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 >>> +++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 >>> @@ -1687,6 +1687,10 @@ >>> *ebx |= (v->vcpu_id * 2) << 24; >>> if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) >>> __clear_bit(X86_FEATURE_APIC & 31, edx); >>> + } else if ( input == 0x0000000b ) >>> + { >>> + /* fix the x2apicid */ >>> + *edx = v->vcpu_id * 2; >>> } >>> } >>> >>> >> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kamble, Nitin A
2009-May-07 18:16 UTC
[Xen-devel] RE: [patch] provide uniqe x2apicid for each vcpu in the cpuid leaf 0xb
Thank you!>Hm, ok, well I think it is a pretty inoffensive patch anyway. I can queue >it >for post 3.4. > > - Keir > > >On 07/05/2009 17:48, "Kamble, Nitin A" <nitin.a.kamble@intel.com> wrote: > >> Keir, >> It is be used to find out the extended cpu topology specified in >the >> leaf 0xb. >> >> Thanks & Regards, >> Nitin >> Linux Open Source Technology Center, Intel Corporation >> ------------------------------------------------------------------------- >--- >> The Mind is like a parachute; it works much better when it''s open. >> >>> -----Original Message----- >>> From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] >>> Sent: Thursday, May 07, 2009 12:05 AM >>> To: Kamble, Nitin A >>> Cc: xen-devel@lists.xensource.com >>> Subject: Re: [patch] provide uniqe x2apicid for each vcpu in the cpuid >leaf >>> 0xb >>> >>> What''s the point of emulating an x2apicid when we don''t emulate an >x2apic? >>> >>> -- Keir >>> >>> On 06/05/2009 23:11, "Nitin A Kamble" <nitin.a.kamble@intel.com> wrote: >>> >>>> Keir, >>>> >>>> Just like the apicid, x2apicid is also unique to each cpu. x2apicid is >>>> coming from edx register of the cpuid leaf 0xb. >>>> >>>> Please Apply/comment. >>>> >>>> Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com> >>>> >>>> >>>> diff -r 08618cd10522 xen/arch/x86/hvm/hvm.c >>>> --- a/xen/arch/x86/hvm/hvm.c Mon May 04 14:13:49 2009 -0700 >>>> +++ b/xen/arch/x86/hvm/hvm.c Mon May 04 14:19:05 2009 -0700 >>>> @@ -1687,6 +1687,10 @@ >>>> *ebx |= (v->vcpu_id * 2) << 24; >>>> if ( vlapic_hw_disabled(vcpu_vlapic(v)) ) >>>> __clear_bit(X86_FEATURE_APIC & 31, edx); >>>> + } else if ( input == 0x0000000b ) >>>> + { >>>> + /* fix the x2apicid */ >>>> + *edx = v->vcpu_id * 2; >>>> } >>>> } >>>> >>>> >>> >> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel