Xen devel - Apr 2009 - [PATCH] Fix search pathes in python code

Hi,

Attached patch gets rid of hardcoded search pathes in python code.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Christoph Egger writes ("[Xen-devel] [PATCH] Fix search pathes in python
code"):
> Attached patch gets rid of hardcoded search pathes in python code.
This is an interesting and useful thing to do in principle.  What it
actually does is have the build system write the installation paths
into the python code.  I think this is much more correct than the
existing arrangements.

I haven''t however tested this specific change :-).  What platforms did
you test it on, and with what build process ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On Tuesday 21 April 2009 18:01:53 Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] Fix search pathes in
python
code"):
> > Attached patch gets rid of hardcoded search pathes in python code.
>
> This is an interesting and useful thing to do in principle.  What it
> actually does is have the build system write the installation paths
> into the python code.  I think this is much more correct than the
> existing arrangements.
>
> I haven''t however tested this specific change :-).  What platforms
did
> you test it on,
NetBSD and Linux.
> and with what build process ? 
in xen toplevel source directory run

   gmake dist-tools

or

  PREFIX="/usr/local" gmake dist-tools

Then have a look into dist/install, copy the files
to your test machine machine,
set LD_LIBRARY_PATH and PYTHONPATH
and see if things work - i.e. if "xm console <domain>" finds the
xenconsole binary.

<side-note>
Once we use rpath, then setting LD_LIBRARY_PATH won''t be
necessary anymore.
</side-note>

Christoph

P.S.: I''m really wondering why Linux distributors don''t send
such patches.
I think, they modify the xen build system to fit into their rpm''s.


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel