Is there a mailing list for commits to the qemu repositories? They
don''t seem to go to
xen-changelog and I didn''t see a separate list @
http://lists.xensource.com/?
Also, FYI, I''m seeing the following with today''s commits to
qemu-xen-unstable.git
/tank/ws/xvm-unstable/qemu.hg/hw/vga.c:1492: warning: redundant
redeclaration of ''rgb_to_pixel_dup_table''
/tank/ws/xvm-unstable/qemu.hg/hw/vga.c:1228: warning: previous
declaration of ''rgb_to_pixel_dup_table'' was here
"hw/vga.c" line 1228 of 2832 --43%-- col 31
--
static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS];
"hw/vga.c" line 1492 of 2832 --52%-- col 31
--
static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS] = {
rgb_to_pixel8_dup,
rgb_to_pixel15_dup,
rgb_to_pixel16_dup,
rgb_to_pixel32_dup,
rgb_to_pixel32bgr_dup,
};
Thanks,
MRJ
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Mark Johnson writes ("[Xen-devel] qemu
repositories"):> Is there a mailing list for commits to the qemu repositories? They
> don''t seem to go to
> xen-changelog and I didn''t see a separate list @
http://lists.xensource.com/?
They are supposed to go to xen-changelog. I did set this up and if I
remember rightly it appeared to be working, but looking at my copy of
the xen-changelog list it seems broken.
> Also, FYI, I''m seeing the following with today''s commits
to
> qemu-xen-unstable.git
> /tank/ws/xvm-unstable/qemu.hg/hw/vga.c:1492: warning: redundant
> redeclaration of ''rgb_to_pixel_dup_table''
> /tank/ws/xvm-unstable/qemu.hg/hw/vga.c:1228: warning: previous
> declaration of ''rgb_to_pixel_dup_table'' was here
Oh, sorry, I missed that. I''ll look into it.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Mark Johnson writes ("[Xen-devel] qemu
repositories"):> "hw/vga.c" line 1228 of 2832 --43%-- col 31
> --
> static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS];
>
> "hw/vga.c" line 1492 of 2832 --52%-- col 31
> --
> static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS] = {
> rgb_to_pixel8_dup,
The earlier declaration is necessary because the table is referred to
in the intervening code. My compiler doesn''t warn about this.
Can you try this change and let me know if it helps ?
Thanks,
Ian.
diff --git a/hw/vga.c b/hw/vga.c
index 7b8572a..71cbcc2 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1225,7 +1225,7 @@ static const uint8_t cursor_glyph[32 * 4] = {
typedef unsigned int rgb_to_pixel_dup_func(unsigned int r, unsigned int g,
unsigned b);
-static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS];
+static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[];
/*
* Text mode update
--
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Thu, Apr 16, 2009 at 6:51 AM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:> Mark Johnson writes ("[Xen-devel] qemu repositories"): >> "hw/vga.c" line 1228 of 2832 --43%-- col 31 >> -- >> static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS]; >> >> "hw/vga.c" line 1492 of 2832 --52%-- col 31 >> -- >> static rgb_to_pixel_dup_func *rgb_to_pixel_dup_table[NB_DEPTHS] = { >> rgb_to_pixel8_dup, > > The earlier declaration is necessary because the table is referred to > in the intervening code. My compiler doesn''t warn about this. > > Can you try this change and let me know if it helps ?Yes, that works fine.. Thanks, MRJ _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel