Hi, Attached patches get rid of hardcoded install path, fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR). All in all, a command like PREFIX="/usr/local" gmake dist now installs everything into dist/install/usr/local instead of dist/install/usr The xen_build.diff is for xen tree, xen_build_ioemu.diff is for ioemu git tree. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger writes ("[PATCH] Fixes for build/install
system"):> Attached patches get rid of hardcoded install path,
> fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR).
> All in all, a command like PREFIX="/usr/local" gmake dist
> now installs everything into dist/install/usr/local
> instead of dist/install/usr
This is all very nice but
> install-doc: $(DOCS)
> - mkdir -p "$(DESTDIR)$(docdir)"
> + $(INSTALL_DIR) "$(DESTDIR)$(docdir)"
> $(INSTALL) -m 644 qemu-doc.html qemu-tech.html
"$(DESTDIR)$(docdir)"
these are parts of the Makefile which come from upstream qemu.
I definitely don''t want to modify those parts. Everything which is
done in the makefiles in qemu-xen-unstable is aimed at avoiding large
textual changes which make merging difficult. We don''t want changes
in our versions of the upstream makefiles which are not absolutely
necessary to make things work.
It''s not clear to me by inspection whether I can safely apply the
other parts of your qemu patch on their own. Can you confirm ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-Apr-01 07:44 UTC
[Xen-devel] Re: [PATCH] Fixes for build/install system
On Tuesday 31 March 2009 18:11:45 Ian Jackson wrote:> Christoph Egger writes ("[PATCH] Fixes for build/install system"): > > Attached patches get rid of hardcoded install path, > > fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR). > > All in all, a command like PREFIX="/usr/local" gmake dist > > now installs everything into dist/install/usr/local > > instead of dist/install/usr > > This is all very nice but > > > install-doc: $(DOCS) > > - mkdir -p "$(DESTDIR)$(docdir)" > > + $(INSTALL_DIR) "$(DESTDIR)$(docdir)" > > $(INSTALL) -m 644 qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)" > > these are parts of the Makefile which come from upstream qemu. > I definitely don''t want to modify those parts. Everything which is > done in the makefiles in qemu-xen-unstable is aimed at avoiding large > textual changes which make merging difficult. We don''t want changes > in our versions of the upstream makefiles which are not absolutely > necessary to make things work. > > It''s not clear to me by inspection whether I can safely apply the > other parts of your qemu patch on their own. Can you confirm ?Yes, I can confirm. It is just less consistent throughout the whole xen build/install system. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2009-Apr-22 15:46 UTC
[Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Hi, Attached patch has some fixes for the build/install system which allows to use qemu-dm when the whole xen tree is build with a different PREFIX. Singed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Apr-23 15:43 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("[Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> install-doc: $(DOCS)
> - mkdir -p "$(DESTDIR)$(docdir)"
> - $(INSTALL) -m 644 qemu-doc.html qemu-tech.html
"$(DESTDIR)$(docdir)"
> + $(INSTALL_DIR) "$(DESTDIR)$(docdir)"
> + $(INSTALL_DATA) qemu-doc.html qemu-tech.html
"$(DESTDIR)$(docdir)"
> ifndef CONFIG_WIN32
> - mkdir -p "$(DESTDIR)$(mandir)/man1"
> - $(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1"
> - mkdir -p "$(DESTDIR)$(mandir)/man8"
> - $(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8"
> + $(INSTALL_DIR) "$(DESTDIR)$(MAN1DIR)"
> + $(INSTALL_DATA) qemu.1 qemu-img.1 "$(DESTDIR)$(MAN1DIR)"
> + $(INSTALL_DIR) "$(DESTDIR)$(MAN8DIR)"
> + $(INSTALL_DATA) qemu-nbd.8 "$(DESTDIR)$(MAN8DIR)"
Once again, these are changes to code from upstream. I see that this
change has been applied upstream. Please try to avoid submitting
changes for inclusion both in upstream and in qemu-xen-unstable. That
causes trouble when I pull. If there is a compelling reason why
the change should be included in Xen before we get it via upstream in
the usual course of events, then we might relax this rule but you
should mention this fact and give an explanation.
In this case the upstream change comes too late to be included in 3.4
- it is (quite correctly) only on the upstream main branch, not on the
upstream stable branch.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-Apr-23 15:54 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Thursday 23 April 2009 17:43:30 Ian Jackson wrote:> Christoph Egger writes ("[Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > install-doc: $(DOCS) > > - mkdir -p "$(DESTDIR)$(docdir)" > > - $(INSTALL) -m 644 qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)" > > + $(INSTALL_DIR) "$(DESTDIR)$(docdir)" > > + $(INSTALL_DATA) qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)" > > ifndef CONFIG_WIN32 > > - mkdir -p "$(DESTDIR)$(mandir)/man1" > > - $(INSTALL) -m 644 qemu.1 qemu-img.1 "$(DESTDIR)$(mandir)/man1" > > - mkdir -p "$(DESTDIR)$(mandir)/man8" > > - $(INSTALL) -m 644 qemu-nbd.8 "$(DESTDIR)$(mandir)/man8" > > + $(INSTALL_DIR) "$(DESTDIR)$(MAN1DIR)" > > + $(INSTALL_DATA) qemu.1 qemu-img.1 "$(DESTDIR)$(MAN1DIR)" > > + $(INSTALL_DIR) "$(DESTDIR)$(MAN8DIR)" > > + $(INSTALL_DATA) qemu-nbd.8 "$(DESTDIR)$(MAN8DIR)" > > Once again, these are changes to code from upstream. I see that this > change has been applied upstream. Please try to avoid submitting > changes for inclusion both in upstream and in qemu-xen-unstable. That > causes trouble when I pull. If there is a compelling reason why > the change should be included in Xen before we get it via upstream in > the usual course of events, then we might relax this rule but you > should mention this fact and give an explanation. > > In this case the upstream change comes too late to be included in 3.4 > - it is (quite correctly) only on the upstream main branch, not on the > upstream stable branch. > > Ian.Attached w/o qemu specific changes. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Apr-23 17:19 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> Attached w/o qemu specific changes.
Thanks. I did a clean test rebuild with these changes and the layout
of the dist/install/ tree had changed substantially. I presume that
wasn''t intentional. If it was, it''s not appropriate for 3.4
at this
stage.
Did you do a similar test ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-Apr-24 06:34 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Thursday 23 April 2009 19:19:14 Ian Jackson wrote:> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > Attached w/o qemu specific changes. > > Thanks. I did a clean test rebuild with these changes and the layout > of the dist/install/ tree had changed substantially. I presume that > wasn''t intentional. If it was, it''s not appropriate for 3.4 at this > stage.Can you send me the output of find dist/install ? Then I can tell you. Did you set PREFIX explicitely or did you use the default values ?> Did you do a similar test ?I run my tests with clean rebuilds from the toplevel xen directory with gmake dist or PREFIX="/usr/local" gmake dist Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Apr-29 15:30 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> Can you send me the output of
> find dist/install ? Then I can tell you.
I don''t have it to hand but stuff had moved into usr/local from usr,
possibly amongst other changes.
> Did you set PREFIX explicitely or did you use the default values ?
I did not set PREFIX.
> > Did you do a similar test ?
>
> I run my tests with clean rebuilds from the toplevel xen directory with
> gmake dist or PREFIX="/usr/local" gmake dist
The purpose of your changes is to plumb PREFIX through to the qemu
build system. But I think you should also test that a default build
remains unchanged.
ccache is your friend here, along with rsync -a --delete.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-May-04 09:42 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Wednesday 29 April 2009 17:30:47 Ian Jackson wrote:> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > Can you send me the output of > > find dist/install ? Then I can tell you. > > I don''t have it to hand but stuff had moved into usr/local from usr, > possibly amongst other changes. > > > Did you set PREFIX explicitely or did you use the default values ? > > I did not set PREFIX. > > > > Did you do a similar test ? > > > > I run my tests with clean rebuilds from the toplevel xen directory with > > gmake dist or PREFIX="/usr/local" gmake dist > > The purpose of your changes is to plumb PREFIX through to the qemu > build system. But I think you should also test that a default build > remains unchanged.I figured out why a default build installs ioemu into /usr/local with my patch: PREFIX is empty and ioemu''s configure sets prefix to /usr/local if prefix is empty. Attached patch fixes this (and applies to the xen-tree). It always passes PREFIX to xen-setup and xen-setup-stubdom. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-May-05 14:00 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> I figured out why a default build installs ioemu into /usr/local with
> my patch: PREFIX is empty and ioemu''s configure sets prefix
> to /usr/local if prefix is empty.
Thanks.
> Attached patch fixes this (and applies to the xen-tree). It always passes
> PREFIX to xen-setup and xen-setup-stubdom.
Could you please do this in xen-setup-* instead, rather than in
xen-unstable''s Makefiles ? That (a) avoids coupling between the two
repositories and (b) will mean that xen-setup will do the right thing
when run by hand.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-May-05 14:15 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Tuesday 05 May 2009 16:00:12 Ian Jackson wrote:> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > I figured out why a default build installs ioemu into /usr/local with > > my patch: PREFIX is empty and ioemu''s configure sets prefix > > to /usr/local if prefix is empty. > > Thanks. > > > Attached patch fixes this (and applies to the xen-tree). It always passes > > PREFIX to xen-setup and xen-setup-stubdom. > > Could you please do this in xen-setup-* instead, rather than in > xen-unstable''s Makefiles ? That (a) avoids coupling between the two > repositories and (b) will mean that xen-setup will do the right thing > when run by hand.I tried, but it doesn''t work. It has to be set _before_ xen-setup* is called for the same reason XEN_ROOT is set in xen-unstable''s Makefiles. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-May-05 14:28 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> On Tuesday 05 May 2009 16:00:12 Ian Jackson wrote:
> > Could you please do this in xen-setup-* instead, rather than in
> > xen-unstable''s Makefiles ? That (a) avoids coupling between
the two
> > repositories and (b) will mean that xen-setup will do the right thing
> > when run by hand.
>
> I tried, but it doesn''t work. It has to be set _before_ xen-setup*
is called
> for the same reason XEN_ROOT is set in xen-unstable''s Makefiles.
I don''t understand, I''m afraid.
XEN_ROOT needs to be handled the way it is because it''s (a) available
only as a make variable in the xen-unstable makefiles and (b) is a
relative pathname so needs to be massaged for use by a sub-component.
If you run xen-setup it guesses a value for XEN_ROOT which is right
for at least one common case.
PREFIX could be set in the environment perfectly well and doesn''t need
any massaging. You could just have xen-setup invent a default PREFIX
if none was found in its environment.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-May-05 15:25 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Tuesday 05 May 2009 16:28:23 Ian Jackson wrote:> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > On Tuesday 05 May 2009 16:00:12 Ian Jackson wrote: > > > Could you please do this in xen-setup-* instead, rather than in > > > xen-unstable''s Makefiles ? That (a) avoids coupling between the two > > > repositories and (b) will mean that xen-setup will do the right thing > > > when run by hand. > > > > I tried, but it doesn''t work. It has to be set _before_ xen-setup* is > > called for the same reason XEN_ROOT is set in xen-unstable''s Makefiles. > > I don''t understand, I''m afraid. > > XEN_ROOT needs to be handled the way it is because it''s (a) available > only as a make variable in the xen-unstable makefiles and (b) is a > relative pathname so needs to be massaged for use by a sub-component. > If you run xen-setup it guesses a value for XEN_ROOT which is right > for at least one common case.PREFIX is defined by xen build system as a make variable. xen''s build system runs some shell code to pass XEN_ROOT as a shell variable to xen-setup. My patch adds some shell code to pass PREFIX as a shell variable to xen-setup, too. xen-setup can guess XEN_ROOT due to the directory structure relative to xen''s toplevel source directory. But how should xen-setup guess an install directory ?> PREFIX could be set in the environment perfectly well and doesn''t need > any massaging. You could just have xen-setup invent a default PREFIX > if none was found in its environment.No, this would end up in having different prefixes on NetBSD at least. xen tools go to /usr/pkg and ioemu goes to /usr/local - great! If you don''t know a way how to make xen-setup to read the PREFIX make variable from xen''s build system, then my patch is the only way to go. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-May-05 17:22 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> No, this would end up in having different prefixes on NetBSD at least.
> xen tools go to /usr/pkg and ioemu goes to /usr/local - great!
>
> If you don''t know a way how to make xen-setup to read the PREFIX
> make variable from xen''s build system,
It might be possible to have the generated makefiles (eg, the various
xen-*.mak) contrive to use the value from the Xen build system
regardless.
> then my patch is the only way to go.
I''m afraid that that patch is not suitable because it breaks the
output locations when you run xen-setup by hand. It''s essential to
allow people to run xen-setup by hand as that''s the only way to
reliably rerun from scratch just the qemu-xen-unstable part of the
build system.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2009-May-08 09:29 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
On Tuesday 05 May 2009 19:22:26 Ian Jackson wrote:> Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes forbuild/install system"):> > No, this would end up in having different prefixes on NetBSD at least. > > xen tools go to /usr/pkg and ioemu goes to /usr/local - great! > > > > If you don''t know a way how to make xen-setup to read the PREFIX > > make variable from xen''s build system, > > It might be possible to have the generated makefiles (eg, the various > xen-*.mak) contrive to use the value from the Xen build system > regardless. > > > then my patch is the only way to go. > > I''m afraid that that patch is not suitable because it breaks the > output locations when you run xen-setup by hand.Why do you want to have ioemu separately? It''s part of xen tools and useless on its own. That''s my understanding at least.> It''s essential to allow people to run xen-setup by hand as that''s the > only way to reliably rerun from scratch just the qemu-xen-unstable > part of the build system.I attached a new version of xen_build_ioemu.diff which sets PREFIX to /usr if empty - the default prefix it uses now. Keir: Please apply attached xen_ioemu_prefix.diff to the xen tree. Both patches combined let xen-setup work in both modes: entangled in xen build system and separate as requested by Ian. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-May-08 16:13 UTC
Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for build/install system
Christoph Egger writes ("Re: [Xen-devel] Re: [PATCH] ioemu: Fixes for
build/install system"):> I attached a new version of xen_build_ioemu.diff which sets PREFIX
> to /usr if empty - the default prefix it uses now.
Thanks.
> Keir: Please apply attached xen_ioemu_prefix.diff to the xen tree.
> Both patches combined let xen-setup work in both modes:
> entangled in xen build system and separate as requested by
> Ian.
Then Xen part of this patch is fine and in any case needs to go in
first, I think. Most of the qemu patch is good too. I''m a bit iffy
about whether we should put this into 3.4 at this time, though.
But I had a question about this part:
> --- a/xen-setup-stubdom
> +++ b/xen-setup-stubdom
....> -bindir = \${prefix}/\${LIBLEAFDIR}/xen/bin
> +bindir = \${LIBEXEC}
etc.
I think this stubdom stuff all refers to files as seen within the
stubdom process, not in the external filesystem ?
The installation of the actual stubdom executable (which is actually a
Xen PV guest kernel) is not controlled from the machinery run by
xen-setup-stubdom, is it ?
So shouldn''t this be fixed at /usr ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel