Michal Novotny
2009-Mar-30 06:43 UTC
[Xen-devel] [PATCH] Check for valid CPU_CAP value when creating (constructing) new domain
Hi, This patch implements check for valid cpu_cap value when creating domain (in range 0 to VcpuCount * 100 as when changing scheduler parameters). Signed-off-by: Michal Novotny <minovotn@redhat.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2009-Mar-30 07:07 UTC
Re: [Xen-devel] [PATCH] Check for valid CPU_CAP value when creating (constructing) new domain
Hi Michal, Why does the patch implement only CPU_CAP? You should consider CPU_WEIGHT too. And you should consider scheduler types too. Best regards, Kan Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote:>Hi, > >This patch implements check for valid cpu_cap value when creating domain ( >in range 0 to VcpuCount * 100 as when changing scheduler parameters). > >Signed-off-by: Michal Novotny <minovotn@redhat.com> > > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michal Novotny
2009-Mar-30 07:35 UTC
Re: [Xen-devel] [PATCH] Check for valid CPU_CAP value when creating (constructing) new domain
Hi Kan, this is new version of my patch implementing check for both CPU_CAP and CPU_WEIGHT and also considering int type for both (asserting it). Best regards, Michal Masaki Kanno wrote:> Hi Michal, > > Why does the patch implement only CPU_CAP? > You should consider CPU_WEIGHT too. > And you should consider scheduler types too. > > Best regards, > Kan > > Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote: > > >> Hi, >> >> This patch implements check for valid cpu_cap value when creating domain ( >> in range 0 to VcpuCount * 100 as when changing scheduler parameters). >> >> Signed-off-by: Michal Novotny <minovotn@redhat.com> >> >> >> -------------------------------text/plain------------------------------- >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2009-Mar-30 07:52 UTC
Re: [Xen-devel] [PATCH] Check for valid CPU_CAP value when creating(constructing) new domain
Hi Michal, I have added the following fixes to your patch. - Check scheduler type - Replace tab-indent with space-indent How about the patch? Signed-off-by: Michal Novotny <minovotn@redhat.com> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan Mon, 30 Mar 2009 09:35:42 +0200, Michal Novotny wrote:>Hi Kan, >this is new version of my patch implementing check for both CPU_CAP and >CPU_WEIGHT and also considering int type for both (asserting it). > >Best regards, >Michal > >Masaki Kanno wrote: >> Hi Michal, >> >> Why does the patch implement only CPU_CAP? >> You should consider CPU_WEIGHT too. >> And you should consider scheduler types too. >> >> Best regards, >> Kan >> >> Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote: >> >> >>> Hi, >>> >>> This patch implements check for valid cpu_cap value when creating domain ( >>> in range 0 to VcpuCount * 100 as when changing scheduler parameters). >>> >>> Signed-off-by: Michal Novotny <minovotn@redhat.com> >>> >>> >>> -------------------------------text/plain------------------------------- >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >>> >> >> > > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Michal Novotny
2009-Mar-30 07:55 UTC
Re: [Xen-devel] [PATCH] Check for valid CPU_CAP value when creating(constructing) new domain
Hi Kan, looks fine to me. Sorry about indents - I forgot I was writing it in gedit now and not Midnight Commander editor - and that I forgot about scheduler type. Best regards, Michal Masaki Kanno wrote:> Hi Michal, > > I have added the following fixes to your patch. > - Check scheduler type > - Replace tab-indent with space-indent > > How about the patch? > > Signed-off-by: Michal Novotny <minovotn@redhat.com> > Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> > > Best regards, > Kan > > > Mon, 30 Mar 2009 09:35:42 +0200, Michal Novotny wrote: > > >> Hi Kan, >> this is new version of my patch implementing check for both CPU_CAP and >> CPU_WEIGHT and also considering int type for both (asserting it). >> >> Best regards, >> Michal >> >> Masaki Kanno wrote: >> >>> Hi Michal, >>> >>> Why does the patch implement only CPU_CAP? >>> You should consider CPU_WEIGHT too. >>> And you should consider scheduler types too. >>> >>> Best regards, >>> Kan >>> >>> Mon, 30 Mar 2009 08:43:07 +0200, Michal Novotny wrote: >>> >>> >>> >>>> Hi, >>>> >>>> This patch implements check for valid cpu_cap value when creating domain ( >>>> in range 0 to VcpuCount * 100 as when changing scheduler parameters). >>>> >>>> Signed-off-by: Michal Novotny <minovotn@redhat.com> >>>> >>>> >>>> -------------------------------text/plain------------------------------- >>>> _______________________________________________ >>>> Xen-devel mailing list >>>> Xen-devel@lists.xensource.com >>>> http://lists.xensource.com/xen-devel >>>> >>>> >>> >>> >> -------------------------------text/plain------------------------------- >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel