Hi, attached patch fixes - one regression introduced in c/s 19399: don''t prepend prefix twice - getconf usage: NetBSD always had a 64bit off_t, so it''s not needed. Eliminates prints of "unknown variable" to stderr during build Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 27/03/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> i, > > attached patch fixes > - one regression introduced in c/s 19399: don''t prepend prefix twiceI think this patch breaks LIBEXEC, rather than fixing it. Point out how prefix gets prepended twice and I''ll reconsider. -- Keir> - getconf usage: NetBSD always had a 64bit off_t, so it''s not needed. > Eliminates prints of "unknown variable" to stderr during build_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2009-Mar-27 16:45 UTC
[Xen-devel] Re: [PATCH] xen buildsystem: minor fixes
On Friday 27 March 2009 17:10:26 Keir Fraser wrote:> On 27/03/2009 15:37, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > i, > > > > attached patch fixes > > - one regression introduced in c/s 19399: don''t prepend prefix twice > > I think this patch breaks LIBEXEC, rather than fixing it. Point out how > prefix gets prepended twice and I''ll reconsider. > > -- KeirOh, right. Then my patch for xen-config.mak in ioemu''s git tree is wrong. bindir just needs to be set to ${LIBEXEC} w/o any prefix. Ian didn''t apply it yet.> > - getconf usage: NetBSD always had a 64bit off_t, so it''s not needed. > > Eliminates prints of "unknown variable" to stderr during buildPlease apply this part. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 27/03/2009 16:45, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> I think this patch breaks LIBEXEC, rather than fixing it. Point out how >> prefix gets prepended twice and I''ll reconsider. >> >> -- Keir > > Oh, right. Then my patch for xen-config.mak in ioemu''s git tree is wrong. > bindir just needs to be set to ${LIBEXEC} w/o any prefix. > Ian didn''t apply it yet.That would match with your usage of LIBEXEC in the stubdom Makefile, yes. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel