Cui, Dexuan
2009-Mar-25 10:12 UTC
[Xen-devel] [PATCH]xend: fix hotplug for integrated devices
For integrated devices(with bus number 0), self.find_parent() returns None, causing a python exception here. The patch adds the checking. Signed-off-by: Dexuan Cui <dexuan.cui@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-26 05:20 UTC
Re: [Xen-devel] [PATCH]xend: fix hotplug for integrated devices
On Wed, Mar 25, 2009 at 06:12:03PM +0800, Cui, Dexuan wrote:> For integrated devices(with bus number 0), self.find_parent() returns > None, causing a python exception here. The patch adds the checking.Hi Dexuan, I''m a little unsure what you mean by intergrated devices here. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-Mar-26 05:28 UTC
RE: [Xen-devel] [PATCH]xend: fix hotplug for integrated devices
Simon Horman wrote:> On Wed, Mar 25, 2009 at 06:12:03PM +0800, Cui, Dexuan wrote: >> For integrated devices(with bus number 0), self.find_parent() >> returns None, causing a python exception here. The patch adds the >> checking. > > Hi Dexuan, > > I''m a little unsure what you mean by intergrated devices here.Hi Simon, I mean the devices built with the motherboard. Thanks, -- Dexuan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-26 21:35 UTC
Re: [Xen-devel] [PATCH]xend: fix hotplug for integrated devices
On Thu, Mar 26, 2009 at 01:28:33PM +0800, Cui, Dexuan wrote:> Simon Horman wrote: > > On Wed, Mar 25, 2009 at 06:12:03PM +0800, Cui, Dexuan wrote: > >> For integrated devices(with bus number 0), self.find_parent() > >> returns None, causing a python exception here. The patch adds the > >> checking. > > > > Hi Dexuan, > > > > I''m a little unsure what you mean by intergrated devices here. > > Hi Simon, > I mean the devices built with the motherboard.Hi Dexuan, Thanks for the clarification. Curiously I''m not seeing any problem hotpluging any devices that a built into the mother board (e.g. USB controller) that have a bus number of 0. Am I testing the wrong thing? -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-Mar-27 01:50 UTC
RE: [Xen-devel] [PATCH]xend: fix hotplug for integrated devices
Hi Simon, One possible reason you don't meet with the issue is: your host and BIOS is new enough, so your USB controllers have the PCI Advanced Features that can be used to do FLR. You can verify this by checking the PCI Capabilities List of your USB controllers: they should have a capability ID 0x13. Please see tools/python/xen/util/pci.py (search for PCI_CAP_ID_AF, find_coassigned_devices) for details. Thanks, -- Dexuan -----Original Message----- From: Simon Horman [mailto:horms@verge.net.au] Sent: 2009年3月27日 5:35 To: Cui, Dexuan Cc: Keir Fraser; xen-devel@lists.xensource.com Subject: Re: [Xen-devel] [PATCH]xend: fix hotplug for integrated devices On Thu, Mar 26, 2009 at 01:28:33PM +0800, Cui, Dexuan wrote:> Simon Horman wrote: > > On Wed, Mar 25, 2009 at 06:12:03PM +0800, Cui, Dexuan wrote: > >> For integrated devices(with bus number 0), self.find_parent() > >> returns None, causing a python exception here. The patch adds the > >> checking. > > > > Hi Dexuan, > > > > I'm a little unsure what you mean by intergrated devices here. > > Hi Simon, > I mean the devices built with the motherboard.Hi Dexuan, Thanks for the clarification. Curiously I'm not seeing any problem hotpluging any devices that a built into the mother board (e.g. USB controller) that have a bus number of 0. Am I testing the wrong thing? -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel