Simon Horman
2009-Mar-23 09:56 UTC
[Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
My patch "xend: specify the slot for pass-through devices"
which was included in xen-unstable.hg as changeset 19418:538a64b1ed63
had an omission.
The code included parsing of slots from the configuration file.
And it stored this information in xend. However, it failed
to pass this information on to qemu-xen.
The patch that was posted and applied doesn''t break anything, it just
doesn''t achieve anything either.
Apologies for this omission, it was removed to test
possible regressions, and unfortunately wasn''t replaced
in the version that I posted.
Signed-off-by: Simon Horman <horms@verge.net.au>
---
There are qemu-xen companion patches for this change which have been
posted as "ioemu: specify the slot for pass-through devices"
Index: xen-unstable.hg/tools/python/xen/xend/server/pciif.py
==================================================================---
xen-unstable.hg.orig/tools/python/xen/xend/server/pciif.py 2009-03-23
19:55:21.000000000 +1100
+++ xen-unstable.hg/tools/python/xen/xend/server/pciif.py 2009-03-23
20:24:36.000000000 +1100
@@ -87,8 +87,8 @@ class PciController(DevController):
if vslt is not None:
vslots = vslots + vslt + ";"
- back[''dev-%i'' % pcidevid] =
"%04x:%02x:%02x.%01x" % \
- (domain, bus, slot, func)
+ back[''dev-%i'' % pcidevid] =
"%04x:%02x:%02x.%01x@%02x" % \
+ (domain, bus, slot, func, vslot)
back[''uuid-%i'' % pcidevid] =
pci_config.get(''uuid'', '''')
pcidevid += 1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-24 10:34 UTC
Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
I would like to withdraw this patch for now as it partially breaks hotplug. I will try to come up with a better solution and post it soon. On Mon, Mar 23, 2009 at 08:56:39PM +1100, Simon Horman wrote:> My patch "xend: specify the slot for pass-through devices" > which was included in xen-unstable.hg as changeset 19418:538a64b1ed63 > had an omission. > > The code included parsing of slots from the configuration file. > And it stored this information in xend. However, it failed > to pass this information on to qemu-xen. > > The patch that was posted and applied doesn''t break anything, it just > doesn''t achieve anything either. > > Apologies for this omission, it was removed to test > possible regressions, and unfortunately wasn''t replaced > in the version that I posted. > > Signed-off-by: Simon Horman <horms@verge.net.au> > > --- > > There are qemu-xen companion patches for this change which have been > posted as "ioemu: specify the slot for pass-through devices" > > Index: xen-unstable.hg/tools/python/xen/xend/server/pciif.py > ==================================================================> --- xen-unstable.hg.orig/tools/python/xen/xend/server/pciif.py 2009-03-23 19:55:21.000000000 +1100 > +++ xen-unstable.hg/tools/python/xen/xend/server/pciif.py 2009-03-23 20:24:36.000000000 +1100 > @@ -87,8 +87,8 @@ class PciController(DevController): > if vslt is not None: > vslots = vslots + vslt + ";" > > - back[''dev-%i'' % pcidevid] = "%04x:%02x:%02x.%01x" % \ > - (domain, bus, slot, func) > + back[''dev-%i'' % pcidevid] = "%04x:%02x:%02x.%01x@%02x" % \ > + (domain, bus, slot, func, vslot) > back[''uuid-%i'' % pcidevid] = pci_config.get(''uuid'', '''') > pcidevid += 1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2009-Mar-24 13:39 UTC
Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
Simon Horman writes ("Re: [Xen-devel] [patch] xend: pass slot for
pass-through devices to qemu-xen"):> I would like to withdraw this patch for now as
> it partially breaks hotplug. I will try to come up
> with a better solution and post it soon.
Should any of the related changes in qemu-xen-unstable be backed out ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-24 23:36 UTC
Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
On Tue, Mar 24, 2009 at 01:39:15PM +0000, Ian Jackson wrote:> Simon Horman writes ("Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen"): > > I would like to withdraw this patch for now as > > it partially breaks hotplug. I will try to come up > > with a better solution and post it soon. > > Should any of the related changes in qemu-xen-unstable be backed out ?I don''t think that is necessary, I will double-check. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-24 23:46 UTC
Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
On Wed, Mar 25, 2009 at 10:36:39AM +1100, Simon Horman wrote:> On Tue, Mar 24, 2009 at 01:39:15PM +0000, Ian Jackson wrote: > > Simon Horman writes ("Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen"): > > > I would like to withdraw this patch for now as > > > it partially breaks hotplug. I will try to come up > > > with a better solution and post it soon. > > > > Should any of the related changes in qemu-xen-unstable be backed out ? > > I don''t think that is necessary, I will double-check.Hi Ian, I just checked against: qemu-xen-unstable 545882583159e9cc53cde5965277967092459f37 cirrus: Do not clear vram area to 0xff when not yet allocated. xen-unstable 19425:0477f9061c8a x86: Build fixes and cleanups after Intel MCA changes. While specifying the vslot for non-hotplug pass-through devices does not work (as expected), the other aspects of pass-through and hot-plug seem to be functional. I have small patches for both xen-unstable and qemu-xen-unstable to fix the outstanding user configuration of the vslot for pass-through problem. (The problem being that the user may specify the vslot but neither xend nor qemu-dm will take any notice). I will do some more testing with a view to sending them out later today. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-Mar-25 09:33 UTC
RE: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
Simon Horman wrote:> On Wed, Mar 25, 2009 at 10:36:39AM +1100, Simon Horman wrote: >> On Tue, Mar 24, 2009 at 01:39:15PM +0000, Ian Jackson wrote: >>> Simon Horman writes ("Re: [Xen-devel] [patch] xend: pass slot for >>> pass-through devices to qemu-xen"): >>>> I would like to withdraw this patch for now as >>>> it partially breaks hotplug. I will try to come up >>>> with a better solution and post it soon. >>> >>> Should any of the related changes in qemu-xen-unstable be backed >>> out ? >> >> I don''t think that is necessary, I will double-check. > > Hi Ian, > > I just checked against: > > qemu-xen-unstable > 545882583159e9cc53cde5965277967092459f37 > cirrus: Do not clear vram area to 0xff when not yet allocated. > > xen-unstable > 19425:0477f9061c8a > x86: Build fixes and cleanups after Intel MCA changes. > > While specifying the vslot for non-hotplug pass-through devices > does not work (as expected), the other aspects of pass-through > and hot-plug seem to be functional. > > > I have small patches for both xen-unstable and qemu-xen-unstable to > fix the outstanding user configuration of the vslot for pass-through > problem. (The problem being that the user may specify the vslot but > neither xend nor qemu-dm will take any notice). I will do some more > testing with a view to sending them out later today.Oh, I just saw this mail. :-) BTW, when you send out the patches, could you please also update the Xen VT-d HOWTO(http://wiki.xensource.com/xenwiki/VTdHowTo) accordingly? You may need to ask Stephen Spector(in the CC) for the edit permission to the wiki. Thanks! -- Dexuan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-25 21:31 UTC
Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
On Wed, Mar 25, 2009 at 05:33:30PM +0800, Cui, Dexuan wrote:> > BTW, when you send out the patches, could you please also update the Xen VT-d HOWTO(http://wiki.xensource.com/xenwiki/VTdHowTo) accordingly? > You may need to ask Stephen Spector(in the CC) for the edit permission to the wiki.Sure. I''ll contact Stephen off-list. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel