thr3ads.net - Xen devel - [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure [Mar 2009]

If this information is useful, please help other people find it:
Share via:

Ian Jackson

2009-Mar-18 16:34 UTC

[Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

xen-setup runs the upstream configure script, and ends up
autodetecting various properties of the host and then trying to use
them in stubdom, which works badly.

In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, which
hardcodes the relevant answers.

With these two changes, stubdom should compile again.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff -r d035b66b5b4d stubdom/Makefile
--- a/stubdom/Makefile	Mon Mar 09 15:01:34 2009 +0000
+++ b/stubdom/Makefile	Wed Mar 18 15:48:18 2009 +0000
@@ -6,8 +6,6 @@ export stubdom=y
 export stubdom=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
-
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls --disable-brlapi
--disable-kqemu
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)
@@ -237,8 +235,12 @@ ioemu: cross-zlib cross-libpci libxc
 	[ -f ioemu/config-host.mak ] || \
 	  ( $(absolutify_xen_root); \
 	    cd ioemu ; \
-          CONFIG_STUBDOM=yes XEN_TARGET_ARCH=$(XEN_TARGET_ARCH)
CFLAGS="$(TARGET_CFLAGS)" sh ./xen-setup --cc=$(CC)
--disable-gcc-check $(IOEMU_OPTIONS))
-	CPPFLAGS= TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" $(MAKE) -C ioemu
LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) TOOLS= CONFIG_STUBDOM=yes
+	    LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) \
+	    TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \
+	    TARGET_CFLAGS="$(TARGET_CFLAGS)" \
+	    TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
+	    ./xen-setup-stubdom )
+	$(MAKE) -C ioemu 
 
 ######
 # caml

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Boris Derzhavets

2009-Mar-18 18:45 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Do you expect stub domains to be tested after the most recent patches applied  ?

Boris

--- On Wed, 3/18/09, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than
configure
To: xen-devel@lists.xensource.com
Date: Wednesday, March 18, 2009, 12:34 PM

xen-setup runs the upstream configure script, and ends up
autodetecting various properties of the host and then trying to use
them in stubdom, which works badly.

In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, which
hardcodes the relevant answers.

With these two changes, stubdom should compile again.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff -r d035b66b5b4d stubdom/Makefile
--- a/stubdom/Makefile	Mon Mar 09 15:01:34 2009 +0000
+++ b/stubdom/Makefile	Wed Mar 18 15:48:18 2009 +0000
@@ -6,8 +6,6 @@ export stubdom=y
 export stubdom=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
-
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls
--disable-brlapi --disable-kqemu
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)
@@ -237,8 +235,12 @@ ioemu: cross-zlib cross-libpci libxc
 	[ -f ioemu/config-host.mak ] || \
 	  ( $(absolutify_xen_root); \
 	    cd ioemu ; \
-          CONFIG_STUBDOM=yes XEN_TARGET_ARCH=$(XEN_TARGET_ARCH)
CFLAGS="$(TARGET_CFLAGS)" sh ./xen-setup --cc=$(CC)
--disable-gcc-check $(IOEMU_OPTIONS))
-	CPPFLAGS= TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" $(MAKE) -C ioemu
LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) TOOLS= CONFIG_STUBDOM=yes
+	    LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) \
+	    TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \
+	    TARGET_CFLAGS="$(TARGET_CFLAGS)" \
+	    TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
+	    ./xen-setup-stubdom )
+	$(MAKE) -C ioemu 
 
 ######
 # caml

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Boris Derzhavets

2009-Mar-19 06:18 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

It''s not there:-

root@ServerXen331:/usr/src/xen-unstable.hg/tools/ioemu-remote# git pull
Already up-to-date.
root@ServerXen331:/usr/src/xen-unstable.hg/tools/ioemu-remote# git log|grep
c609854fe18aab3216f28e1e5291b75970d398d5
root@ServerXen331:/usr/src/xen-unstable.hg/tools/ioemu-remote# 

Boris

--- On Wed, 3/18/09, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than
configure
To: xen-devel@lists.xensource.com
Date: Wednesday, March 18, 2009, 12:34 PM

xen-setup runs the upstream configure script, and ends up
autodetecting various properties of the host and then trying to use
them in stubdom, which works badly.

In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, which
hardcodes the relevant answers.

With these two changes, stubdom should compile again.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff -r d035b66b5b4d stubdom/Makefile
--- a/stubdom/Makefile	Mon Mar 09 15:01:34 2009 +0000
+++ b/stubdom/Makefile	Wed Mar 18 15:48:18 2009 +0000
@@ -6,8 +6,6 @@ export stubdom=y
 export stubdom=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
-
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls
--disable-brlapi --disable-kqemu
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)
@@ -237,8 +235,12 @@ ioemu: cross-zlib cross-libpci libxc
 	[ -f ioemu/config-host.mak ] || \
 	  ( $(absolutify_xen_root); \
 	    cd ioemu ; \
-          CONFIG_STUBDOM=yes XEN_TARGET_ARCH=$(XEN_TARGET_ARCH)
CFLAGS="$(TARGET_CFLAGS)" sh ./xen-setup --cc=$(CC)
--disable-gcc-check $(IOEMU_OPTIONS))
-	CPPFLAGS= TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" $(MAKE) -C ioemu
LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) TOOLS= CONFIG_STUBDOM=yes
+	    LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) \
+	    TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \
+	    TARGET_CFLAGS="$(TARGET_CFLAGS)" \
+	    TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
+	    ./xen-setup-stubdom )
+	$(MAKE) -C ioemu 
 
 ######
 # caml

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Boris Derzhavets

2009-Mar-23 15:34 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

>It is not a network problem, the system completely locks up when I try
>to start a stubdom, even the local keyboard and vga is not responsive.
>Andy
In meantime i even cannot build stubdom. 

Per Ian Jackson:-
  In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, 
which hardcodes the relevant answers.

Patch to makefile has been applied in Xen Unstable:-

changeset 19389 ioemu-stubdom: Use xen-setup-stubdom 
rather than configure

But i cannot get mentioned commit, even reinstalling Xen Unstable
with fresh git download for ioemu-remote.

Maybe i misunderstand message bellow.

Boris



--- On Wed, 3/18/09, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than
configure
To: xen-devel@lists.xensource.com
Date: Wednesday, March 18, 2009, 12:34 PM

xen-setup runs the upstream configure script, and ends up
autodetecting various properties of the host and then trying to use
them in stubdom, which works badly.

In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, which
hardcodes the relevant answers.

With these two changes, stubdom should compile again.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff -r d035b66b5b4d stubdom/Makefile
--- a/stubdom/Makefile	Mon Mar 09 15:01:34 2009 +0000
+++ b/stubdom/Makefile	Wed Mar 18 15:48:18 2009 +0000
@@ -6,8 +6,6 @@ export stubdom=y
 export stubdom=y
 export debug=y
 include $(XEN_ROOT)/Config.mk
-
-IOEMU_OPTIONS=--disable-sdl --disable-opengl --disable-vnc-tls
--disable-brlapi --disable-kqemu
 
 #ZLIB_URL?=http://www.zlib.net
 ZLIB_URL=$(XEN_EXTFILES_URL)
@@ -237,8 +235,12 @@ ioemu: cross-zlib cross-libpci libxc
 	[ -f ioemu/config-host.mak ] || \
 	  ( $(absolutify_xen_root); \
 	    cd ioemu ; \
-          CONFIG_STUBDOM=yes XEN_TARGET_ARCH=$(XEN_TARGET_ARCH)
CFLAGS="$(TARGET_CFLAGS)" sh ./xen-setup --cc=$(CC)
--disable-gcc-check $(IOEMU_OPTIONS))
-	CPPFLAGS= TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" $(MAKE) -C ioemu
LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) TOOLS= CONFIG_STUBDOM=yes
+	    LWIPDIR=$(CURDIR)/lwip-$(XEN_TARGET_ARCH) \
+	    TARGET_CPPFLAGS="$(TARGET_CPPFLAGS)" \
+	    TARGET_CFLAGS="$(TARGET_CFLAGS)" \
+	    TARGET_LDFLAGS="$(TARGET_LDFLAGS)" \
+	    ./xen-setup-stubdom )
+	$(MAKE) -C ioemu 
 
 ######
 # caml

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini

2009-Mar-23 16:02 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Boris Derzhavets wrote:
>>It is not a network problem, the system completely locks up when I try
>>to start a stubdom, even the local keyboard and vga is not responsive.
>>Andy
> 
> In meantime i even cannot build stubdom. 
> 
> Per Ian Jackson:-
>   In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
> qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, 
> which hardcodes the relevant answers.
> 
> Patch to makefile has been applied in Xen Unstable:-
> 
> changeset 19389 ioemu-stubdom: Use xen-setup-stubdom 
> rather than configure
> 
> But i cannot get mentioned commit, even reinstalling Xen Unstable
> with fresh git download for ioemu-remote.
> 
> Maybe i misunderstand message bellow.
> 
Try now, the build process should complete successfully.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Ian Jackson

2009-Mar-23 16:15 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Dutch Meyer writes ("Re: [Xen-devel] [PATCH] ioemu-stubdom: Use
xen-setup-stubdom rather than configure"):> Did the associated ioemu change get pushed?  I''m not terribly
familiar
> with git, but it looks to me like the last change to ioemu was last 
> monday.
No, it didn''t.  Apparently the xen-unstable change was pushed
manually.  The qemu-xen-unstable change was languishing in staging and
I have pushed it by hand now.

I think in future we (and I include myself!) should try much harder to
avoid cross-version breakage of this kind.  In this case I should have
made sure that the new script was available and working in
qemu-xen-unstable before submitting the change to xen-unstable.

My apologies.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini

2009-Mar-23 17:02 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Boris Derzhavets wrote:
> Yes , now i can :-
> 
> # cd /usr/src/xen-unstable.hg/stubdom
> # make
> # make install
> 
> Started  fs-backend  ant tried to start stub domain.
> No luck . Nothing listen at localhost:5900
> Boris
I am aware there are still issues with stubdom, you should be able to
see some patches in the next few days.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Boris Derzhavets

2009-Mar-23 17:04 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Yes , now i can :-

# cd /usr/src/xen-unstable.hg/stubdom
# make
# make install

Started  fs-backend  ant tried to start stub domain.
No luck . Nothing listen at localhost:5900
Boris



--- On Mon, 3/23/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather
than configure
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "Andrew Lyon" <andrew.lyon@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Date: Monday, March 23, 2009, 12:02 PM

Boris Derzhavets wrote:
>>It is not a network problem, the system completely locks up when I try
>>to start a stubdom, even the local keyboard and vga is not responsive.
>>Andy
> 
> In meantime i even cannot build stubdom. 
> 
> Per Ian Jackson:-
>   In commit c609854fe18aab3216f28e1e5291b75970d398d5 in
> qemu-xen-unstable we provide a new `xen-setup-stubdom'' script, 
> which hardcodes the relevant answers.
> 
> Patch to makefile has been applied in Xen Unstable:-
> 
> changeset 19389 ioemu-stubdom: Use xen-setup-stubdom 
> rather than configure
> 
> But i cannot get mentioned commit, even reinstalling Xen Unstable
> with fresh git download for ioemu-remote.
> 
> Maybe i misunderstand message bellow.
> 
Try now, the build process should complete successfully.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Stefano Stabellini

2009-Mar-23 17:51 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Boris Derzhavets wrote:
> As far as i understand it supposed to come via git to ioemu-remote.
> Right ?
> Boris
Yes.
I also always send my patches to the mailing list first.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Boris Derzhavets

2009-Mar-23 17:52 UTC

head link

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

As far as i understand it supposed to come via git to ioemu-remote.
Right ?
Boris

--- On Mon, 3/23/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather
than configure
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "Andrew Lyon" <andrew.lyon@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Date: Monday, March 23, 2009, 1:02 PM

Boris Derzhavets wrote:
> Yes , now i can :-
> 
> # cd /usr/src/xen-unstable.hg/stubdom
> # make
> # make install
> 
> Started  fs-backend  ant tried to start stub domain.
> No luck . Nothing listen at localhost:5900
> Boris
I am aware there are still issues with stubdom, you should be able to
see some patches in the next few days.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel



      

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Xen devel - Mar 2009 - [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

[Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure

Re: [Xen-devel] [PATCH] ioemu-stubdom: Use xen-setup-stubdom rather than configure