Yuji Shimada
2009-Mar-17 08:47 UTC
[Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore
This patch fixes getting the configuration of PCI pass-through from xenstore. Thanks, -- Yuji Shimada Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp> diff --git a/vl.c b/vl.c index 9b9f7d5..c0d1df4 100644 --- a/vl.c +++ b/vl.c @@ -5783,6 +5783,9 @@ int main(int argc, char **argv, char **envp) } } + if (strlen(direct_pci_str) > 0) + direct_pci = direct_pci_str; + machine->init(ram_size, vga_ram_size, boot_devices, kernel_filename, kernel_cmdline, initrd_filename, cpu_model, direct_pci); @@ -5901,9 +5904,6 @@ int main(int argc, char **argv, char **envp) } } - if (strlen(direct_pci_str) > 0) - direct_pci = direct_pci_str; - for(i = 0; i < MAX_VIRTIO_CONSOLES; i++) { const char *devname = virtio_consoles[i]; if (virtcon_hds[i] && devname) { _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-17 22:57 UTC
Re: [Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore
On Tue, Mar 17, 2009 at 05:47:39PM +0900, Yuji Shimada wrote:> This patch fixes getting the configuration of PCI pass-through from xenstore.That looks good to me, though I''m a little confused about how it worked without this change. I''m looking at cset 82787c6f689d869ad349df83ec3f58702afe00fe "Override default cache mode for disk images to write-back" -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yuji Shimada
2009-Mar-18 01:27 UTC
Re: [Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore
On Wed, 18 Mar 2009 09:57:00 +1100 Simon Horman <horms@verge.net.au> wrote:> On Tue, Mar 17, 2009 at 05:47:39PM +0900, Yuji Shimada wrote: > > This patch fixes getting the configuration of PCI pass-through from xenstore. > > That looks good to me, though I''m a little confused about > how it worked without this change. > > I''m looking at cset 82787c6f689d869ad349df83ec3f58702afe00fe > "Override default cache mode for disk images to write-back"This cset worked well without my patch. But the latest cset does not work. So I submitted the patch. Thanks, -- Yuji Shimada _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2009-Mar-18 03:43 UTC
Re: [Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore
On Wed, Mar 18, 2009 at 10:27:27AM +0900, Yuji Shimada wrote:> On Wed, 18 Mar 2009 09:57:00 +1100 > Simon Horman <horms@verge.net.au> wrote: > > > On Tue, Mar 17, 2009 at 05:47:39PM +0900, Yuji Shimada wrote: > > > This patch fixes getting the configuration of PCI pass-through from xenstore. > > > > That looks good to me, though I''m a little confused about > > how it worked without this change. > > > > I''m looking at cset 82787c6f689d869ad349df83ec3f58702afe00fe > > "Override default cache mode for disk images to write-back" > > This cset worked well without my patch. > > But the latest cset does not work. > So I submitted the patch.Thanks, though I don''t seem to be able to get the latest cset to work, even with your patch. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Cui, Dexuan
2009-Mar-24 05:33 UTC
RE: [Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore
Acked-by: Dexuan Cui <dexuan.cui@intel.com> BTW, looks the patch is still not in the latest qemu-xen-unstable.git tree. -- Dexuan -----Original Message----- From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Yuji Shimada Sent: 2009年3月17日 16:48 To: xen-devel@lists.xensource.com; Ian Jackson Subject: [Xen-devel] [PATCH] ioemu: Fix getting the configuration of PCI pass-through from xenstore This patch fixes getting the configuration of PCI pass-through from xenstore. Thanks, -- Yuji Shimada Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp> diff --git a/vl.c b/vl.c index 9b9f7d5..c0d1df4 100644 --- a/vl.c +++ b/vl.c @@ -5783,6 +5783,9 @@ int main(int argc, char **argv, char **envp) } } + if (strlen(direct_pci_str) > 0) + direct_pci = direct_pci_str; + machine->init(ram_size, vga_ram_size, boot_devices, kernel_filename, kernel_cmdline, initrd_filename, cpu_model, direct_pci); @@ -5901,9 +5904,6 @@ int main(int argc, char **argv, char **envp) } } - if (strlen(direct_pci_str) > 0) - direct_pci = direct_pci_str; - for(i = 0; i < MAX_VIRTIO_CONSOLES; i++) { const char *devname = virtio_consoles[i]; if (virtcon_hds[i] && devname) { _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel