George Dunlap
2009-Mar-16 15:50 UTC
[Xen-devel] [PATCH][RFC] Parameter name change for xc_*_build functions
[Purely a cosmetic change.] It''s been pointed out that the "memory" parameter names in tools/libxc/xenguest.h aren''t very consistent between linux and HVM, and may confuse people setting up ballooning systems. Ballooning systems generally have a parameter like "static_max", which is the maximum memory the VM will ever have, and "target" which is the memory we want it to have right now (somewhere between dynamic_max and dynamic_min). The attached patch changes the parameter names to make them consistent with what someone building such a system might use: * When building a PV Linux VM, since we can expand the memory whenever we wish, we pass in "start_mem_mb". This corresponds to "target". * When building an HVM VM with xc_hvm_build(), since we cannot grow larger than the initial amount of memory at boot, we pass in "max_mem_mb". This corresponds to "static_max". The balloon driver can then be used after boot to balloon down to target. * When building an HVM VM with xc_hvm_build_target_mem(), we pass both parameters: "max_mem_mb" (which corresponds to "static_max") and "start_mem_mb" (which corresponds to target). Thoughts? -George Dunlap _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel