Jeremy Fitzhardinge
2009-Mar-14 07:04 UTC
[Xen-devel] tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unify the
format decoding layer for its 3 users", causes a regression in xenbus
which results in no devices getting attached to a new domain. Reverting
fef20d9c1380f04ba9492d6463148db07b413708 and
39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem.
I haven''t identified what format string is being handled wrongly, so I
don''t know what the precise bug is. The most complex looking format in
use seems to be %.*s; there''s also "%s/%s", "%i"
and "%lX".
J
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Boris Derzhavets
2009-Mar-14 09:43 UTC
Re: [Xen-devel] tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Two PV DomUs (CentOS 5.2 , F10) have been tested with new kernel
During shutdown of any one of mentioned DomUs usual sequence of
daemon''s messages drops into stack trace with following messages at the
end:-
xenbus_dev_shutdown: device/vif/0 timeout closing device
xenbus_dev_shutdown: device/vbd/51712 timeout closing device
System halted.
After that Xen Host stop responding at all, just dies.
Boris
--- On Sat, 3/14/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: [Xen-devel] tip.git regression from "vsprintf: unify the format
decoding layer for its 3 users"
To: "Frederic Weisbecker" <fweisbec@gmail.com>
Cc: "Xen-devel" <xen-devel@lists.xensource.com>, "Ingo
Molnar" <mingo@elte.hu>, "the arch/x86 maintainers"
<x86@kernel.org>, "Linux Kernel Mailing List"
<linux-kernel@vger.kernel.org>
Date: Saturday, March 14, 2009, 3:04 AM
Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unify the
format decoding layer for its 3 users", causes a regression in xenbus which
results in no devices getting attached to a new domain. Reverting
fef20d9c1380f04ba9492d6463148db07b413708 and
39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem.
I haven''t identified what format string is being handled wrongly, so I
don''t know what the precise bug is. The most complex looking format in
use
seems to be %.*s; there''s also "%s/%s", "%i" and
"%lX".
J
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Mar-14 16:11 UTC
[Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Vegard Nossum wrote:> 2009/3/14 Jeremy Fitzhardinge <jeremy@goop.org>: > >> Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unify the format >> decoding layer for its 3 users", causes a regression in xenbus which results >> in no devices getting attached to a new domain. Reverting >> fef20d9c1380f04ba9492d6463148db07b413708 and >> 39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem. >> >> I haven''t identified what format string is being handled wrongly, so I don''t >> know what the precise bug is. The most complex looking format in use seems >> to be %.*s; there''s also "%s/%s", "%i" and "%lX". >> > > Hi, > > At least %.*s seems to be broken. How about this patch? >Thanks, that does the trick. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Boris Derzhavets
2009-Mar-16 12:32 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
What is the issue status in meantime ? git pull reports conflicting merge ./lib/vsprintf.c PV DomUs may be brought up , but cannot be shutdown. Boris. --- On Sat, 3/14/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote: From: Jeremy Fitzhardinge <jeremy@goop.org> Subject: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users" To: "Vegard Nossum" <vegard.nossum@gmail.com> Cc: "Xen-devel" <xen-devel@lists.xensource.com>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "the arch/x86 maintainers" <x86@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org> Date: Saturday, March 14, 2009, 12:11 PM Vegard Nossum wrote:> 2009/3/14 Jeremy Fitzhardinge <jeremy@goop.org>: > >> Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unifythe format>> decoding layer for its 3 users", causes a regression in xenbuswhich results>> in no devices getting attached to a new domain. Reverting >> fef20d9c1380f04ba9492d6463148db07b413708 and >> 39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem. >> >> I haven''t identified what format string is being handled wrongly,so I don''t>> know what the precise bug is. The most complex looking format in useseems>> to be %.*s; there''s also "%s/%s", "%i" and"%lX".>> > > Hi, > > At least %.*s seems to be broken. How about this patch? >Thanks, that does the trick. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Mar-16 14:20 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Boris Derzhavets wrote:> What is the issue status in meantime ? > git pull reports conflicting merge ./lib/vsprintf.c > PV DomUs may be brought up , but cannot be > shutdown. >Do a "git checkout xen/dom0/hackery; git reset --hard remotes/xen/xen/dom0/hackery" to rebase your local hackery branch to the upstream one. I did a bit of a history-rewrite to replace the reverts with the proper fix. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Boris Derzhavets
2009-Mar-16 16:05 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
It''s not working:- root@ServerIntrepid:/usr/src/linux-2.6-xen# git checkout xen/dom0/hackery Already on "xen/dom0/hackery" root@ServerIntrepid:/usr/src/linux-2.6-xen# git reset --hard remotes/xen/xen/dom0/hackery fatal: ambiguous argument ''remotes/xen/xen/dom0/hackery'': unknown revision or path not in the working tree. Use ''--'' to separate paths from revisions Boris --- On Mon, 3/16/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote: From: Jeremy Fitzhardinge <jeremy@goop.org> Subject: Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users" To: bderzhavets@yahoo.com Cc: "Xen-devel" <xen-devel@lists.xensource.com>, "Vegard Nossum" <vegard.nossum@gmail.com>, "Frederic Weisbecker" <fweisbec@gmail.com>, "the arch/x86 maintainers" <x86@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Ingo Molnar" <mingo@elte.hu> Date: Monday, March 16, 2009, 10:20 AM Boris Derzhavets wrote:> What is the issue status in meantime ? > git pull reports conflicting merge ./lib/vsprintf.c > PV DomUs may be brought up , but cannot be > shutdown. >Do a "git checkout xen/dom0/hackery; git reset --hard remotes/xen/xen/dom0/hackery" to rebase your local hackery branch to the upstream one. I did a bit of a history-rewrite to replace the reverts with the proper fix. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Mar-16 16:09 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Boris Derzhavets wrote:> It''s not working:- > > root@ServerIntrepid:/usr/src/linux-2.6-xen# git checkout xen/dom0/hackery > Already on "xen/dom0/hackery" > root@ServerIntrepid:/usr/src/linux-2.6-xen# git reset --hard > remotes/xen/xen/dom0/hackery > fatal: ambiguous argument ''remotes/xen/xen/dom0/hackery'': unknown > revision or path not in the working tree. >The proper name is "remotes/<whatever you called your xen remote>/xen/dom0/hackery" (it might be "origin"). J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Boris Derzhavets
2009-Mar-16 17:48 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Performed:- root@ServerIntrepid:/usr/src/linux-2.6-xen# git reset --hard remotes/origin/xen/dom0/hackery HEAD is now at a38db50 Merge commit ''tip/core/printk'' into xen/dom0/hackery make clean make make modules_install install mkinitramfs -o /boot/initrd-2.6.29-rc7-tip.img 2.6.29-rc7-tip Booted with new kernel under Xen (19355) and get same bug in place. Cannot shutdown any PV DomU . Xen Host dies. Should i download from scratch :- # git clone git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git linux-2.6-xen # cd linux-2.6-xen # git checkout origin/xen/dom0/hackery -b xen/dom0/hackery # git reset --hard remotes/origin/xen/dom0/hackery Boris --- On Mon, 3/16/09, Jeremy Fitzhardinge <jeremy@goop.org> wrote: From: Jeremy Fitzhardinge <jeremy@goop.org> Subject: Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users" To: bderzhavets@yahoo.com Cc: "Xen-devel" <xen-devel@lists.xensource.com>, "Vegard Nossum" <vegard.nossum@gmail.com>, "Frederic Weisbecker" <fweisbec@gmail.com>, "the arch/x86 maintainers" <x86@kernel.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>, "Ingo Molnar" <mingo@elte.hu> Date: Monday, March 16, 2009, 12:09 PM Boris Derzhavets wrote:> It''s not working:- > > root@ServerIntrepid:/usr/src/linux-2.6-xen# git checkout xen/dom0/hackery > Already on "xen/dom0/hackery" > root@ServerIntrepid:/usr/src/linux-2.6-xen# git reset --hardremotes/xen/xen/dom0/hackery> fatal: ambiguous argument ''remotes/xen/xen/dom0/hackery'': unknownrevision or path not in the working tree.>The proper name is "remotes/<whatever you called your xen remote>/xen/dom0/hackery" (it might be "origin"). J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2009-Mar-16 17:55 UTC
Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
Boris Derzhavets wrote:> Performed:- > > root@ServerIntrepid:/usr/src/linux-2.6-xen# git reset --hard > remotes/origin/xen/dom0/hackery > HEAD is now at a38db50 Merge commit ''tip/core/printk'' into > xen/dom0/hackery > make clean > make > make modules_install install > mkinitramfs -o /boot/initrd-2.6.29-rc7-tip.img 2.6.29-rc7-tip > > Booted with new kernel under Xen (19355) and get same bug in place. > Cannot shutdown any PV DomU . Xen Host dies. >OK, so we''re talking about a new bug now, right? When you say "Xen Host dies", do you mean that Xen itself crashes? Or that the dom0 kernel crashes? Hangs? Non-responsive? Do you have a serial console? J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel