John Levon
2009-Mar-12 01:45 UTC
[Xen-devel] [PATCH] Crash the domain if qemu-dm stops running
# HG changeset patch
# User John Levon <john.levon@sun.com>
# Date 1236822295 25200
# Node ID 4a4bbf70a1fa246d132f2e709039c330a5506fe9
# Parent 93d25b0df1be0abc503ff721e291b6a1553f4da2
Crash the domain if qemu-dm stops running
The comment about the lack of restart prevention is not accurate.
Bump the minimum restart time to 60 seconds.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/python/xen/xend/XendConstants.py
b/tools/python/xen/xend/XendConstants.py
--- a/tools/python/xen/xend/XendConstants.py
+++ b/tools/python/xen/xend/XendConstants.py
@@ -96,7 +96,7 @@ ZOMBIE_PREFIX = ''Zombie-''
ZOMBIE_PREFIX = ''Zombie-''
"""Minimum time between domain restarts in
seconds."""
-MINIMUM_RESTART_TIME = 20
+MINIMUM_RESTART_TIME = 60
RESTART_IN_PROGRESS = ''xend/restart_in_progress''
DUMPCORE_IN_PROGRESS = ''xend/dumpcore_in_progress''
diff --git a/tools/python/xen/xend/image.py b/tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py
+++ b/tools/python/xen/xend/image.py
@@ -487,11 +487,7 @@ class ImageHandler:
def _dmfailed(self, message):
log.warning("domain %s: %s", self.vm.getName(), message)
- # ideally we would like to forcibly crash the domain with
- # something like
- # xc.domain_shutdown(self.vm.getDomid(), DOMAIN_CRASH)
- # but this can easily lead to very rapid restart loops against
- # which we currently have no protection
+ xc.domain_shutdown(self.vm.getDomid(), DOMAIN_CRASH)
def recreate(self):
if self.device_model is None:
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Zhang, Yang
2009-May-18 02:26 UTC
RE: [Xen-devel] [PATCH] Crash the domain if qemu-dm stops running
John Levon wrote:> # HG changeset patch > # User John Levon <john.levon@sun.com> > # Date 1236822295 25200 > # Node ID 4a4bbf70a1fa246d132f2e709039c330a5506fe9 > # Parent 93d25b0df1be0abc503ff721e291b6a1553f4da2 > Crash the domain if qemu-dm stops running > > The comment about the lack of restart prevention is not accurate. > > Bump the minimum restart time to 60 seconds. > > Signed-off-by: John Levon <john.levon@sun.com> > > diff --git a/tools/python/xen/xend/XendConstants.py > b/tools/python/xen/xend/XendConstants.py --- > a/tools/python/xen/xend/XendConstants.py +++ > b/tools/python/xen/xend/XendConstants.py @@ -96,7 +96,7 @@ > ZOMBIE_PREFIX = ''Zombie-'' ZOMBIE_PREFIX = ''Zombie-'' > > """Minimum time between domain restarts in seconds.""" > -MINIMUM_RESTART_TIME = 20 > +MINIMUM_RESTART_TIME = 60why we changed the MINIMUM_RESTART_TIME to 60? _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel