Jeremy Fitzhardinge
2009-Feb-07 00:31 UTC
[Xen-devel] [GIT PULL] x86: unify some of kernel/irq*.c
These changes factor out the differences between 32 and 64-bit do_IRQ and unify the rest. Unfortunately there are still quite a few other differences (like interrupt stack handling) which preclude further easy unification. Thanks, J The following changes since commit f21daa4d04885a34d1972afa9f82a8aebb6152bb: Ingo Molnar (1): Merge branch ''out-of-tree'' are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git jsgf/x86/unify-irq Jeremy Fitzhardinge (2): x86: add handle_irq() to allow interrupt injection x86: unify do_IRQ() arch/x86/include/asm/irq.h | 4 +++- arch/x86/kernel/irq.c | 38 ++++++++++++++++++++++++++++++++++++++ arch/x86/kernel/irq_32.c | 29 +++++------------------------ arch/x86/kernel/irq_64.c | 34 +++++----------------------------- 4 files changed, 51 insertions(+), 54 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ingo Molnar
2009-Feb-09 10:29 UTC
[Xen-devel] Re: [GIT PULL] x86: unify some of kernel/irq*.c
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:> These changes factor out the differences between 32 and 64-bit do_IRQ > and unify the rest. Unfortunately there are still quite a few other > differences (like interrupt stack handling) which preclude further easy > unification. > > Thanks, > J > > The following changes since commit f21daa4d04885a34d1972afa9f82a8aebb6152bb: > Ingo Molnar (1): > Merge branch ''out-of-tree'' > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git jsgf/x86/unify-irq > > Jeremy Fitzhardinge (2): > x86: add handle_irq() to allow interrupt injectionWhy doesnt Xen use a special irqchip, instead of this private hook/layer in the lowlevel x86 arch level? irqchip is at least well-specified and widely used. do_IRQ() internals on the other hand will become a Xen special quickly. Also, adding a needless function call there obviously does not help native performance. Ingo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel