Xen devel - Feb 2009 - [PATCH 1/9] tmem: Public interface for tmem

[1] Public interface for tmem

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Dan Magenheimer <dan.magenheimer@oracle.com> 06.02.09 01:40
>>>
>[1] Public interface for tmem
Couldn''t the whole second hunk rather go in a separate header?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Thanks for the feedback!
> Couldn''t the whole second hunk rather go in a separate header?
Are you referring to the constants and the data structure?
All of these are used by both xen and a guest and must
be identical, thus the placement in public/xen.h.  Are there
other header files which are guaranteed to be shared between
xen and a (linux) guest?

Thanks,
Dan
> -----Original Message-----
> From: Jan Beulich [mailto:jbeulich@novell.com]
> Sent: Friday, February 06, 2009 1:47 AM
> To: Dan Magenheimer
> Cc: xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] [PATCH 1/9] tmem: Public interface for tmem
> 
> 
> >>> Dan Magenheimer <dan.magenheimer@oracle.com> 06.02.09
01:40 >>>
> >[1] Public interface for tmem
> 
> Couldn''t the whole second hunk rather go in a separate header?
> 
> Jan
> 
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

>>> Dan Magenheimer <dan.magenheimer@oracle.com> 06.02.09 15:08
>>>
>> Couldn''t the whole second hunk rather go in a separate header?
>
>Are you referring to the constants and the data structure?
>All of these are used by both xen and a guest and must
>be identical, thus the placement in public/xen.h.  Are there
>other header files which are guaranteed to be shared between
>xen and a (linux) guest?
All headers in xen/include/public/. You could create a new one, or (less
ideal) put it in xen/include/public/memory.h.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel