Hi, When we don''t specify PXE boot in guest configuration file, it is not necessary for hvmloader to load PXE option ROM. This patch avoid unncessary loading the rom. It can save shadow memory area for option ROMs. Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-18 14:40 UTC
Re: [Xen-devel] [Patch] avoid unnecessary loading NIC rom.
On 18/12/2008 13:45, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:> When we don''t specify PXE boot in guest configuration file, > it is not necessary for hvmloader to load PXE option ROM. > This patch avoid unncessary loading the rom. > It can save shadow memory area for option ROMs.There''s a ''F10 to select boot device'' option in rombios, so you can''t determine this in hvmloader. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Akio Takebe
2008-Dec-18 14:50 UTC
Re: [Xen-devel] [Patch] avoid unnecessary loading NIC rom.
Keir Fraser wrote:> On 18/12/2008 13:45, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote: > >> When we don''t specify PXE boot in guest configuration file, >> it is not necessary for hvmloader to load PXE option ROM. >> This patch avoid unncessary loading the rom. >> It can save shadow memory area for option ROMs. > > There''s a ''F10 to select boot device'' option in rombios, so you can''t > determine this in hvmloader.Exactly. But if gPXE rom is loaded, hvmloader cannot load some option ROMs of raal PCI cards. I suspect we don''t use F10 option for PXE boot. Do you have good idea? Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-18 14:55 UTC
Re: [Xen-devel] [Patch] avoid unnecessary loading NIC rom.
On 18/12/2008 14:50, "Akio Takebe" <takebe_akio@jp.fujitsu.com> wrote:>> There''s a ''F10 to select boot device'' option in rombios, so you can''t >> determine this in hvmloader. > Exactly. But if gPXE rom is loaded, > hvmloader cannot load some option ROMs of raal PCI cards. > I suspect we don''t use F10 option for PXE boot. > Do you have good idea?Not really. Perhaps scan_etherboot_nic() after pci_load_option_roms(), so the latter takes priority? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Dec-18 15:00 UTC
Re: [Xen-devel] [Patch] avoid unnecessary loading NIC rom.
On 18/12/2008 14:55, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:>>> There''s a ''F10 to select boot device'' option in rombios, so you can''t >>> determine this in hvmloader. >> Exactly. But if gPXE rom is loaded, >> hvmloader cannot load some option ROMs of raal PCI cards. >> I suspect we don''t use F10 option for PXE boot. >> Do you have good idea? > > Not really. Perhaps scan_etherboot_nic() after pci_load_option_roms(), so the > latter takes priority?Another possibility is to let option ROMs load up to 0xe9000 rather than just 0xe0000. There''s nothing in the range 0xe0000-0xe9000 right now; it''s 36kB of wasted space. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Akio Takebe
2008-Dec-19 07:37 UTC
Re: [Xen-devel] [Patch] avoid unnecessary loading NIC rom.
Keir Fraser wrote:> On 18/12/2008 14:55, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote: > >>>> There''s a ''F10 to select boot device'' option in rombios, so you can''t >>>> determine this in hvmloader. >>> Exactly. But if gPXE rom is loaded, >>> hvmloader cannot load some option ROMs of raal PCI cards. >>> I suspect we don''t use F10 option for PXE boot. >>> Do you have good idea? >> Not really. Perhaps scan_etherboot_nic() after pci_load_option_roms(), so the >> latter takes priority? > > Another possibility is to let option ROMs load up to 0xe9000 rather than > just 0xe0000. There''s nothing in the range 0xe0000-0xe9000 right now; it''s > 36kB of wasted space. >OK. I''ll try to use the range 0xe0000-0xe9000. The range seems to be OK in BBS spec. Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel