Simon Horman
2008-Nov-14 03:35 UTC
[Xen-devel] [patch] paravirt_ops hypervisor.h needs SIF_INITDOMAIN from xen.h
When building 2172:6126f283df46 of http://xenbits.xensource.com/paravirt_ops/patches.hg on x86_32 I encounter the following build error after x86-parse-xen-lapic.patch is applied. # gcc --version gcc (Debian 4.3.2-1) 4.3.2 Copyright (C) 2008 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. # make CHK include/linux/version.h CHK include/linux/utsrelease.h SYMLINK include/asm -> include/asm-x86 CALL scripts/checksyscalls.sh CHK include/linux/compile.h CC arch/x86/kernel/acpi/boot.o arch/x86/kernel/acpi/boot.c: In function ''acpi_register_lapic'': arch/x86/kernel/acpi/boot.c:240: error: dereferencing pointer to incomplete type arch/x86/kernel/acpi/boot.c:240: error: ''SIF_INITDOMAIN'' undeclared (first use in this function) arch/x86/kernel/acpi/boot.c:240: error: (Each undeclared identifier is reported only once arch/x86/kernel/acpi/boot.c:240: error: for each function it appears in.) arch/x86/kernel/acpi/boot.c: In function ''acpi_register_lapic_address'': arch/x86/kernel/acpi/boot.c:765: error: dereferencing pointer to incomplete type arch/x86/kernel/acpi/boot.c:765: error: ''SIF_INITDOMAIN'' undeclared (first use in this function) make[2]: *** [arch/x86/kernel/acpi/boot.o] Error 1 make[1]: *** [arch/x86/kernel/acpi] Error 2 make: *** [arch/x86/kernel] Error 2 Signed-off-by: Simon Horman <horms@verge.net.au> Index: linux-2.6/arch/x86/include/asm/xen/hypervisor.h ==================================================================--- linux-2.6.orig/arch/x86/include/asm/xen/hypervisor.h 2008-11-14 09:13:11.000000000 +1100 +++ linux-2.6/arch/x86/include/asm/xen/hypervisor.h 2008-11-14 10:06:44.000000000 +1100 @@ -33,6 +33,8 @@ #ifndef _ASM_X86_XEN_HYPERVISOR_H #define _ASM_X86_XEN_HYPERVISOR_H +#include <xen/interface/xen.h> + /* arch/i386/kernel/setup.c */ extern struct shared_info *HYPERVISOR_shared_info; extern struct start_info *xen_start_info; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jeremy Fitzhardinge
2008-Nov-14 05:09 UTC
[Xen-devel] Re: [patch] paravirt_ops hypervisor.h needs SIF_INITDOMAIN from xen.h
Simon Horman wrote:> When building 2172:6126f283df46 of > http://xenbits.xensource.com/paravirt_ops/patches.hg on x86_32 I encounter > the following build error after x86-parse-xen-lapic.patch is applied. >What config? Does it go away if you apply more of the patch series? I don''t see this, so I''m wondering under what circumstances it does happen. J _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Simon Horman
2008-Nov-14 09:49 UTC
Re: [Xen-devel] Re: [patch] paravirt_ops hypervisor.h needs SIF_INITDOMAIN from xen.h
On Thu, Nov 13, 2008 at 09:09:08PM -0800, Jeremy Fitzhardinge wrote:> Simon Horman wrote: >> When building 2172:6126f283df46 of >> http://xenbits.xensource.com/paravirt_ops/patches.hg on x86_32 I encounter >> the following build error after x86-parse-xen-lapic.patch is applied. >> > > What config?Hi Jeremy, The default config seems to show this problem.> Does it go away if you apply more of the patch series? I > don''t see this, so I''m wondering under what circumstances it does happen.I poked a bit harder, and it seems that applying xen-dom0-config.patch resolves the problems. Perhaps some (minor?) munging so that xen-dom0-config.patch is applied before x86-parse-xen-lapic.patch would be a good solution. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel