Xen devel - Nov 2008 - [PATCH 0] CPU affinity reset during save/restore

Hi,

Even though there is a quite old cs 14588
(http://xenbits.xensource.com/xen-unstable.hg?rev/853853686147) described as a
fix to this issue, the CPU affinity is still reset after dom-U being saved and
restored in current xen-unstable.

I found two reasons for this. First, although XendConfig._parse_sxp() tries to
parse the affinity from ''cpus'', the list is not stored in
domain''s checkpoint
file. This is because cs 15152
(http://xenbits.xensource.com/xen-unstable.hg?rev/681ed46676a6) prevents
''cpus'' list to be generated in XendConfig.to_sxp().

Second, even though ''cpus'' is correctly parsed in
XendConfig._parse_sxp(), it
is not used for setting CPU affinity in XendDomainInfo.resume().

That said, after reverting cs 14588 and applying the attached patch, the CPU
affinity is correctly restored after restoring the domain.

The attached patch just copies the code related to CPU affinity from
XendDomainInfo._initDomain() into XendDomainInfo._setCPUAffinity() and calls
this method from _initDomain() and resume().

What do you think about this way to fix the CPU affinity reset? If it is not
the right way, what way do you prefer this issue to be fixed?

Any comments how the patch could be improved are most welcome.

Cheers,

Jirka

-- 
Today is the first day of the rest of your life.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel