I have to admit that I don''t recall the exact details of where I ran into a problem without this change, but it''s a prerequisite for the highmem-assist patch. Signed-off-by: Jan Beulich <jbeulich@novell.com> Index: 2008-09-19/xen/include/asm-x86/fixmap.h ==================================================================--- 2008-09-19.orig/xen/include/asm-x86/fixmap.h 2008-09-15 11:25:43.000000000 +0200 +++ 2008-09-19/xen/include/asm-x86/fixmap.h 2008-09-19 14:00:01.000000000 +0200 @@ -29,6 +29,7 @@ * from the end of virtual memory backwards. */ enum fixed_addresses { + FIX_HOLE, #ifdef __i386__ FIX_PAE_HIGHMEM_0, FIX_PAE_HIGHMEM_END = FIX_PAE_HIGHMEM_0 + NR_CPUS-1, _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
If no explanation can be given as to why this makes the highmem-assist patch work, I can only reasonably take neither patch. -- Keir On 27/10/08 11:38, "Jan Beulich" <jbeulich@novell.com> wrote:> I have to admit that I don''t recall the exact details of where I ran > into a problem without this change, but it''s a prerequisite for the > highmem-assist patch. > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > > Index: 2008-09-19/xen/include/asm-x86/fixmap.h > ==================================================================> --- 2008-09-19.orig/xen/include/asm-x86/fixmap.h 2008-09-15 11:25:43.000000000 > +0200 > +++ 2008-09-19/xen/include/asm-x86/fixmap.h 2008-09-19 14:00:01.000000000 > +0200 > @@ -29,6 +29,7 @@ > * from the end of virtual memory backwards. > */ > enum fixed_addresses { > + FIX_HOLE, > #ifdef __i386__ > FIX_PAE_HIGHMEM_0, > FIX_PAE_HIGHMEM_END = FIX_PAE_HIGHMEM_0 + NR_CPUS-1, > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
>>> Keir Fraser <keir.fraser@eu.citrix.com> 27.10.08 13:06 >>> >If no explanation can be given as to why this makes the highmem-assist patch >work, I can only reasonably take neither patch.Okay, okay, I recalled the problem after some staring at fixmap.h: The BUG_ON() in virt_to_fix() would trigger on FIX_PAE_HIGHMEM_0 without the hole, as fix_to_virt() on that index returns FIXADDR_TOP.>On 27/10/08 11:38, "Jan Beulich" <jbeulich@novell.com> wrote: > >> I have to admit that I don''t recall the exact details of where I ran >> into a problem without this change, but it''s a prerequisite for the >> highmem-assist patch. >> >> Signed-off-by: Jan Beulich <jbeulich@novell.com>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel