cpufreq_del_cpu() calls cpufreq_driver->exit() without checking whether
an exit() handler is present, and by adding an exit() handler to
powernow we can at once close the potential memory leak.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Index: 2008-09-19/xen/arch/x86/acpi/cpufreq/powernow.c
==================================================================---
2008-09-19.orig/xen/arch/x86/acpi/cpufreq/powernow.c 2008-09-19
15:44:48.000000000 +0200
+++ 2008-09-19/xen/arch/x86/acpi/cpufreq/powernow.c 2008-10-14
14:36:04.000000000 +0200
@@ -229,9 +229,23 @@ err_unreg:
return result;
}
+static int powernow_cpufreq_cpu_exit(struct cpufreq_policy *policy)
+{
+ struct powernow_cpufreq_data *data = drv_data[policy->cpu];
+
+ if (data) {
+ drv_data[policy->cpu] = NULL;
+ xfree(data->freq_table);
+ xfree(data);
+ }
+
+ return 0;
+}
+
static struct cpufreq_driver powernow_cpufreq_driver = {
.target = powernow_cpufreq_target,
.init = powernow_cpufreq_cpu_init,
+ .exit = powernow_cpufreq_cpu_exit
};
int powernow_cpufreq_init(void)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel