Liu, Jinsong
2008-Oct-21 02:49 UTC
[Xen-devel][PATCH 1] X86: Adapt 32b guest os to 64b hypervisor platform_hypercall compatibility
Changeset 18552 (19b0a4f91712) move px transfer logic from platform_hypercall.c to a common file to support both x86 and ia64. However, it involves 32b guest os to 64b hypervisor (x86) compatible issue. This patch fix the compatible issue, and make set_px_pminfo() re-used by ia64 and x86 (32b guest os to 64b hypervisor, and 64b guest os to 64b hypervisor). Signed-off-by: Liu Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Jan Beulich
2008-Oct-21 09:23 UTC
Re: [Xen-devel][PATCH 1] X86: Adapt 32b guest os to 64b hypervisorplatform_hypercall compatibility
>>> "Liu, Jinsong" <jinsong.liu@intel.com> 21.10.08 04:49 >>> >--- a/xen/include/xlat.lst Tue Oct 07 17:23:04 2008 +0800 >+++ b/xen/include/xlat.lst Tue Oct 14 18:41:53 2008 +0800 >@@ -55,3 +55,7 @@ > ! processor_cx platform.h > ! processor_flags platform.h > ! processor_power platform.h >+! pct_register platform.h >+! processor_px platform.h >+! psd_package platform.h >+! processor_performance platform.hIt would seem to me that only processor_performance needs translation, the other three just need checking here. That should simplify the actual code doing the translation, as now you don''t really need to translate what xen_processor_performance.states points to - all you need to do is translate the handle itself. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Liu, Jinsong
2008-Oct-22 07:02 UTC
RE: [Xen-devel][PATCH 1] X86: Adapt 32b guest os to 64b hypervisorplatform_hypercall compatibility
Jan, Thanks for suggestion! As for pct_register and psd_package, they still need translation, since ''XLAT_pct_register'' and ''XLAT_psd_package'' were needed in ''XLAT_processor_performance''. As for processor_px, it''s good to just checking and translate handle. I''ve updated the hypercall compatible patch and sent out to xen-dev list. Thanks, Jinsong Jan Beulich wrote:>>>> "Liu, Jinsong" <jinsong.liu@intel.com> 21.10.08 04:49 >>> >> --- a/xen/include/xlat.lst Tue Oct 07 17:23:04 2008 +0800 >> +++ b/xen/include/xlat.lst Tue Oct 14 18:41:53 2008 +0800 @@ -55,3 >> +55,7 @@ ! processor_cx platform.h >> ! processor_flags platform.h >> ! processor_power platform.h >> +! pct_register platform.h >> +! processor_px platform.h >> +! psd_package platform.h >> +! processor_performance platform.h > > It would seem to me that only processor_performance needs translation, > the other three just need checking here. That should simplify the > actual code doing the translation, as now you don''t really need to > translate what xen_processor_performance.states points to - all you > need to do > is translate the handle itself. > > Jan_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel