c/s 18434 in xen-3.3-testing has a hunk that changes gatherDom() to _gatherDom() in tools/python/xen/xend/image.py. There is no such method, thus simple "xm list" fails jfehlig4: # xm li Error: _gatherDom Usage: xm list [options] [Domain, ...] .. Trivial fix attached. BTW, I don''t see this patch in xen-unstable. Why is this only in xen3.3-testing? Thanks, Jim Signed-off-by: Jim Fehlig <jfehlig@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 8/10/08 18:47, "Jim Fehlig" <jfehlig@novell.com> wrote:> c/s 18434 in xen-3.3-testing has a hunk that changes gatherDom() to > _gatherDom() in tools/python/xen/xend/image.py. There is no such > method, thus simple "xm list" fails > > jfehlig4: # xm li > Error: _gatherDom > Usage: xm list [options] [Domain, ...] > .. > > Trivial fix attached. BTW, I don''t see this patch in xen-unstable. Why > is this only in xen3.3-testing?It is in xen-unstable, as c/s 18564 (which is part of xen-3.3-testing:18434). The bug is a stupid typo, and I will apply your patch to both trees. Thanks, Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser wrote:> On 8/10/08 18:47, "Jim Fehlig" <jfehlig@novell.com> wrote: > > >> c/s 18434 in xen-3.3-testing has a hunk that changes gatherDom() to >> _gatherDom() in tools/python/xen/xend/image.py. There is no such >> method, thus simple "xm list" fails >> >> jfehlig4: # xm li >> Error: _gatherDom >> Usage: xm list [options] [Domain, ...] >> .. >> >> Trivial fix attached. BTW, I don''t see this patch in xen-unstable. Why >> is this only in xen3.3-testing? >> > > It is in xen-unstable, as c/s 18564 (which is part of > xen-3.3-testing:18434).Missed that, sorry. I''ve also found that this c/s causes /local/domain/0/backend/{vkbd, vfb, console} paths to leak :(. Patch attached. Thanks, Jim Signed-off-by: Jim Fehlig <jfehlig@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 9/10/08 23:02, "Jim Fehlig" <jfehlig@novell.com> wrote:> Missed that, sorry. > > I''ve also found that this c/s causes /local/domain/0/backend/{vkbd, vfb, > console} paths to leak :(. Patch attached.A major point of the patch was to stop reading the backend link from the frontend directory. Is the problem that /vm/... is getting deleted too early? Could we delay it? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser wrote:> On 9/10/08 23:02, "Jim Fehlig" <jfehlig@novell.com> wrote: > > >> Missed that, sorry. >> >> I''ve also found that this c/s causes /local/domain/0/backend/{vkbd, vfb, >> console} paths to leak :(. Patch attached. >> > > A major point of the patch was to stop reading the backend link from the > frontend directory.Ah, right. I should have looked at the patch more closely :-/> Is the problem that /vm/... is getting deleted too > early? Could we delay it? >Turns out that we were just constructing the path incorrectly. Patch attached. Thanks, Jim Signed-off-by: Jim Fehlig <jfehlig@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel