Isaku Yamahata
2008-Sep-29 02:58 UTC
Re: [Xen-ia64-devel] add pci configuration code, which is needed by VTD
On Sat, Sep 27, 2008 at 01:40:49PM +0800, Xu, Anthony wrote:> Add pci configuration code, which is needed by VTD > > Signed-off-by; Anthony Xu < anthony.xu@intel.com > > > > The new one, I put pci.c under arch/ia64/xen, since it only uses two functions of linux pci.c, > I don''t want to pull the whole pci.c in xen.I see. I understood why you ended in the patch. Hmm, looking at xen-unstable.hg/xen/arch/x86/pci.c, Only pci_conf_read()/pci_conf_write() are different, other functions seems same to x86''s. So please split out same functions into arch common file, probably xen/drivers/pci/pci.c or something acceptable for Keir. Then add pci_conf_read()/pci_conf_write() in xen/arch/ia64/xen/pci.c. -- yamahata _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Xu, Anthony
2008-Oct-09 09:36 UTC
RE: [Xen-ia64-devel] add pci configuration code, which is needed by VTD
Isaku Yamahata wrote:> On Sat, Sep 27, 2008 at 01:40:49PM +0800, Xu, Anthony wrote: >> Add pci configuration code, which is needed by VTD >> >> Signed-off-by; Anthony Xu < anthony.xu@intel.com > >> >> >> The new one, I put pci.c under arch/ia64/xen, since it only uses two >> functions of linux pci.c, I don''t want to pull the whole pci.c in >> xen. > > I see. I understood why you ended in the patch. > Hmm, looking at xen-unstable.hg/xen/arch/x86/pci.c, > Only pci_conf_read()/pci_conf_write() are different, other functions > seems same to x86''s. > So please split out same functions into arch common file, > probably xen/drivers/pci/pci.c or something acceptable for Keir. > Then add pci_conf_read()/pci_conf_write() in xen/arch/ia64/xen/pci.c.Good suggestion! I''ll make the patches. BTW, how about the other two patches I sent out? Thanks, Anthony _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
Isaku Yamahata
2008-Oct-10 03:01 UTC
Re: [Xen-ia64-devel] add pci configuration code, which is needed by VTD
On Thu, Oct 09, 2008 at 05:36:57PM +0800, Xu, Anthony wrote:> Isaku Yamahata wrote: > > On Sat, Sep 27, 2008 at 01:40:49PM +0800, Xu, Anthony wrote: > >> Add pci configuration code, which is needed by VTD > >> > >> Signed-off-by; Anthony Xu < anthony.xu@intel.com > > >> > >> > >> The new one, I put pci.c under arch/ia64/xen, since it only uses two > >> functions of linux pci.c, I don''t want to pull the whole pci.c in > >> xen. > > > > I see. I understood why you ended in the patch. > > Hmm, looking at xen-unstable.hg/xen/arch/x86/pci.c, > > Only pci_conf_read()/pci_conf_write() are different, other functions > > seems same to x86''s. > > So please split out same functions into arch common file, > > probably xen/drivers/pci/pci.c or something acceptable for Keir. > > Then add pci_conf_read()/pci_conf_write() in xen/arch/ia64/xen/pci.c. > > Good suggestion! > I''ll make the patches.I applied the patch without two functions in order to fix compilation error.> BTW, how about the other two patches I sent out?I applied both. thanks, -- yamahata _______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel