KUWAMURA Shin''ya
2008-Aug-13 08:27 UTC
[Xen-devel] Sync domctl.h for XEN_DOMCTL_subscribe
Hi, On ia64, saving PV domains and HVM domains with PV-on-HVM drivers fail with the following error: xc_save: failed to subscribe to domain: -1 This patch is required for adding XEN_DOMCTL_subscribe to xencomm in order to support ia64. Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> -- KUWAMURA Shin''ya _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Kouya Shimura
2008-Aug-13 09:21 UTC
[Xen-devel] Re: [Xen-ia64-devel] Sync domctl.h for XEN_DOMCTL_subscribe
Hi Keir, Could you synchronize other stuff too? $ diff -r linux-2.6.18-xen.hg/include/xen/interface xen-unstable.hg/xen/include/public | diffstat linux-2.6.18-xen.hg/include/xen/interface/acm.h |only linux-2.6.18-xen.hg/include/xen/interface/acm_ops.h |only linux-2.6.18-xen.hg/include/xen/interface/arch-powerpc.h |only linux-2.6.18-xen.hg/include/xen/interface/foreign |only linux-2.6.18-xen.hg/include/xen/interface/hvm/vmx_assist.h |only linux-2.6.18-xen.hg/include/xen/interface/io/vscsiif.h |only xen-unstable.hg/xen/include/public/arch-ia64.h | 1 xen-unstable.hg/xen/include/public/arch-x86/xen-mca.h |only xen-unstable.hg/xen/include/public/arch-x86/xen.h | 4 + xen-unstable.hg/xen/include/public/hvm/hvm_op.h | 34 +++++++++++++ xen-unstable.hg/xen/include/public/hvm/params.h | 5 + xen-unstable.hg/xen/include/public/io/fbif.h | 21 +++++++- xen-unstable.hg/xen/include/public/io/fsif.h | 26 ++++++--- xen-unstable.hg/xen/include/public/kexec.h | 24 ++++++++- xen-unstable.hg/xen/include/public/memory.h | 26 +++++++-- xen-unstable.hg/xen/include/public/physdev.h | 2 xen-unstable.hg/xen/include/public/trace.h | 11 +++- xen-unstable.hg/xen/include/public/xen-compat.h | 2 xen-unstable.hg/xen/include/public/xsm/flask_op.h | 8 +-- 19 files changed, 137 insertions(+), 27 deletions(-) Thanks, Kouya KUWAMURA Shin''ya writes:> Hi, > > On ia64, saving PV domains and HVM domains with PV-on-HVM drivers > fail with the following error: > xc_save: failed to subscribe to domain: -1 > > This patch is required for adding XEN_DOMCTL_subscribe to xencomm in > order to support ia64. > > Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> > -- > KUWAMURA Shin''ya > # HG changeset patch > # User KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> > # Date 1218605915 -32400 > # Node ID 6fdc45f4931e37db85de89a4f45018e25fd52d57 > # Parent cdd156cb645bc1ea1dce7b1b4ed42e2b4928383d > Sync domctl.h for XEN_DOMCTL_subscribe > > Signed-off-by: KUWAMURA Shin''ya <kuwa@jp.fujitsu.com> > > diff -r cdd156cb645b -r 6fdc45f4931e include/xen/interface/domctl.h > --- a/include/xen/interface/domctl.h Mon Aug 11 11:05:57 2008 +0900 > +++ b/include/xen/interface/domctl.h Wed Aug 13 14:38:35 2008 +0900 > @@ -448,6 +448,16 @@ typedef struct xen_domctl_assign_device > typedef struct xen_domctl_assign_device xen_domctl_assign_device_t; > DEFINE_XEN_GUEST_HANDLE(xen_domctl_assign_device_t); > > +/* Retrieve sibling devices infomation of machine_bdf */ > +#define XEN_DOMCTL_get_device_group 50 > +struct xen_domctl_get_device_group { > + uint32_t machine_bdf; /* IN */ > + uint32_t max_sdevs; /* IN */ > + uint32_t num_sdevs; /* OUT */ > + XEN_GUEST_HANDLE_64(uint32) sdev_array; /* OUT */ > +}; > +typedef struct xen_domctl_get_device_group xen_domctl_get_device_group_t; > +DEFINE_XEN_GUEST_HANDLE(xen_domctl_get_device_group_t); > > /* Pass-through interrupts: bind real irq -> hvm devfn. */ > #define XEN_DOMCTL_bind_pt_irq 38 > @@ -589,6 +599,21 @@ typedef struct xen_domctl_cpuid xen_domc > typedef struct xen_domctl_cpuid xen_domctl_cpuid_t; > DEFINE_XEN_GUEST_HANDLE(xen_domctl_cpuid_t); > #endif > + > +#define XEN_DOMCTL_subscribe 29 > +struct xen_domctl_subscribe { > + uint32_t port; /* IN */ > +}; > +typedef struct xen_domctl_subscribe xen_domctl_subscribe_t; > +DEFINE_XEN_GUEST_HANDLE(xen_domctl_subscribe_t); > + > +/* > + * Define the maximum machine address size which should be allocated > + * to a guest. > + */ > +#define XEN_DOMCTL_set_machine_address_size 51 > +#define XEN_DOMCTL_get_machine_address_size 52 > + > > struct xen_domctl { > uint32_t cmd; > @@ -619,6 +644,7 @@ struct xen_domctl { > struct xen_domctl_hvmcontext hvmcontext; > struct xen_domctl_address_size address_size; > struct xen_domctl_sendtrigger sendtrigger; > + struct xen_domctl_get_device_group get_device_group; > struct xen_domctl_assign_device assign_device; > struct xen_domctl_bind_pt_irq bind_pt_irq; > struct xen_domctl_memory_mapping memory_mapping; > @@ -627,6 +653,7 @@ struct xen_domctl { > struct xen_domctl_ext_vcpucontext ext_vcpucontext; > struct xen_domctl_set_opt_feature set_opt_feature; > struct xen_domctl_set_target set_target; > + struct xen_domctl_subscribe subscribe; > #if defined(__i386__) || defined(__x86_64__) > struct xen_domctl_cpuid cpuid; > #endif > _______________________________________________ > Xen-ia64-devel mailing list > Xen-ia64-devel@lists.xensource.com > http://lists.xensource.com/xen-ia64-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, Aug 13, 2008 at 05:27:18PM +0900, KUWAMURA Shin''ya wrote:> This patch is required for adding XEN_DOMCTL_subscribe to xencomm inThese domctl''s seem to be missing from ChangeLog too john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel