Zhao, Yu
2008-Aug-06 09:23 UTC
[Xen-devel] [PATCH] pass-through: Fix I/O BAR mapping probblem
Check BAR type indicator to avoid I/O BAR being mistaken as 64-bit memory BAR.
hw/pass-through.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/pass-through.c b/hw/pass-through.c
index 7b46234..6d5686f 100644
--- a/hw/pass-through.c
+++ b/hw/pass-through.c
@@ -1511,7 +1511,9 @@ static int pt_bar_reg_parse(
/* check 64bit BAR */
index = pt_bar_offset_to_index(reg->offset);
if ((index > 0) && (index < PCI_ROM_SLOT) &&
- (d->config[bar_64] & PCI_BASE_ADDRESS_MEM_TYPE_64))
+ ((d->config[bar_64] & (PCI_BASE_ADDRESS_SPACE |
+ PCI_BASE_ADDRESS_MEM_TYPE_MASK)) =+
(PCI_BASE_ADDRESS_SPACE_MEMORY | PCI_BASE_ADDRESS_MEM_TYPE_64)))
{
region = &ptdev->bases[index-1];
if (region->bar_flag != PT_BAR_FLAG_UPPER)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Zhao, Yu
2008-Aug-06 09:25 UTC
RE: [Xen-devel] [PATCH] pass-through: Fix I/O BAR mapping probblem
Signed-off-by: Yu Zhao <yu.zhao@intel.com>>-----Original Message----- >From: Zhao, Yu >Sent: Wednesday, August 06, 2008 5:24 PM >To: Keir Fraser >Cc: xen-devel@lists.xensource.com >Subject: [Xen-devel] [PATCH] pass-through: Fix I/O BAR mapping probblem > >Check BAR type indicator to avoid I/O BAR being mistaken as 64-bit memory BAR. > >hw/pass-through.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/hw/pass-through.c b/hw/pass-through.c >index 7b46234..6d5686f 100644 >--- a/hw/pass-through.c >+++ b/hw/pass-through.c >@@ -1511,7 +1511,9 @@ static int pt_bar_reg_parse( > /* check 64bit BAR */ > index = pt_bar_offset_to_index(reg->offset); > if ((index > 0) && (index < PCI_ROM_SLOT) && >- (d->config[bar_64] & PCI_BASE_ADDRESS_MEM_TYPE_64)) >+ ((d->config[bar_64] & (PCI_BASE_ADDRESS_SPACE | >+ PCI_BASE_ADDRESS_MEM_TYPE_MASK)) =>+ (PCI_BASE_ADDRESS_SPACE_MEMORY | PCI_BASE_ADDRESS_MEM_TYPE_64))) > { > region = &ptdev->bases[index-1]; > if (region->bar_flag != PT_BAR_FLAG_UPPER)_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel