Hi, Attached patch makes xenperf''s functions static which have no prototypes. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
How many more of these are there going to be? -- Keir On 15/7/08 14:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi, > > Attached patch makes xenperf''s functions static which have no prototypes. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tuesday 15 July 2008 15:39:42 Keir Fraser wrote:> How many more of these are there going to be?One more (already sent). Then the tools build with the additional compiler flags: -Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type -Wnested-externs -Wredundant-decls -Wfloat-equal -Wundef -Wimplicit-function-declaration Is there a way to add them w/o adding them to the xen-kernel ? Christoph> > -- Keir > > On 15/7/08 14:36, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi, > > > > Attached patch makes xenperf''s functions static which have no prototypes. > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 15/7/08 14:45, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> One more (already sent). Then the tools build with the additional compiler > flags: > > -Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type > -Wnested-externs > -Wredundant-decls -Wfloat-equal -Wundef -Wimplicit-function-declarationDo we really want these? Certainly I''m not going to play whack-a-warning with umpteen versions of gcc before 3.3 is out. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Tuesday 15 July 2008 15:52:13 Keir Fraser wrote:> On 15/7/08 14:45, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > One more (already sent). Then the tools build with the additional > > compiler flags: > > > > -Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type > > -Wnested-externs > > -Wredundant-decls -Wfloat-equal -Wundef -Wimplicit-function-declaration > > Do we really want these? Certainly I''m not going to play whack-a-warning > with umpteen versions of gcc before 3.3 is out.Probably not all of them. -Wfloat-equal has no effect because there''s no FPU code in Xen. The flags -Wmissing-prototypes -Wnested-externs -Wredundant-decls and -Wimplicit-function-declaration resulted in the patches I sent yesterday and today. These flags guarantee that future patches have a higher quality. For the xen-kernel itself I''m not yet through with these flags. Nonetheless, I can send a patch you will like. :) Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 15/7/08 15:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> For the xen-kernel itself I''m not yet through with these flags. > Nonetheless, I can send a patch you will like. :)I doubt it. :-) -- keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2008-Jul-15 14:41 UTC
[PATCH][XEN] cleanup (was: Re: [Xen-devel] [PATCH][TOOLS] xenperf: cleanup)
On Tuesday 15 July 2008 16:16:27 Keir Fraser wrote:> On 15/7/08 15:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > For the xen-kernel itself I''m not yet through with these flags. > > Nonetheless, I can send a patch you will like. :) > > I doubt it. :-) > > -- keirThen check this out! :-) Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Jul-15 14:44 UTC
Re: [PATCH][XEN] cleanup (was: Re: [Xen-devel] [PATCH][TOOLS] xenperf: cleanup)
On 15/7/08 15:41, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> On 15/7/08 15:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>> For the xen-kernel itself I''m not yet through with these flags. >>> Nonetheless, I can send a patch you will like. :) >> >> I doubt it. :-) >> >> -- keir > > Then check this out! :-) > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>Is that really the whole thing, and not 1 of N? It''s very pleasantly surprising if so! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Christoph Egger
2008-Jul-15 15:05 UTC
Re: [PATCH][XEN] cleanup (was: Re: [Xen-devel] [PATCH][TOOLS] xenperf: cleanup)
On Tuesday 15 July 2008 16:44:40 Keir Fraser wrote:> On 15/7/08 15:41, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >> On 15/7/08 15:06, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > >>> For the xen-kernel itself I''m not yet through with these flags. > >>> Nonetheless, I can send a patch you will like. :) > >> > >> I doubt it. :-) > >> > >> -- keir > > > > Then check this out! :-) > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > > Is that really the whole thing, and not 1 of N? It''s very pleasantly > surprising if so! > > -- KeirNo, that''s just the part you like :) All hypercall functions need a prototype, for example, and there are a lot of redundant declarations. Christoph -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel