Christopher Head
2008-Jul-05 06:20 UTC
[Xen-devel] Blktap extended device number support bug
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, In xenlinux revision 582, domid_translate_t is redefined from containing a pair of unsigned shorts to contain an unsigned short and a u32. Unfortunately, down on lines 772 and 773 of drivers/xen/blktap/blktap.c, a domid_translate_t is built out of an unsigned long. This of course doesn''t work, because domid_translate_t is now 48 bits long while unsigned long is only 32. I suggest passing a pointer into the ioctl and doing a proper user-to-kernel copy. Also, the userspace tools in xen-3.2-testing also need modifying as they have their own copy of the struct declaration (and will in any case need updating to pass a pointer instead of the struct packed into an unsigned long). Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: GnuPT 2.7.2 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhvEq8ACgkQiD2svb/jCb7rOQCfUhWy+k+oJfGnu6tgJKVAdH4m gccAn0AUoEE5MNJ6BLSVmytt5tHkIXHV =VvIn -----END PGP SIGNATURE----- _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel