Chen, Huacai
2008-Jun-06 00:54 UTC
[Xen-devel] [patch]Fix a bug that can''t resume from S3 after create an HVM guest
Hi, Keir, If we don''t use PIT, we should disable it at boot time and at S3 resuming. In Xen this is done by disable_pit_irq(), but this function is used by __initcall(). After bootstrap it will be discarded and may be overwritten. This usually results in S3 resuming failure. This patch fixed the issue. Signed-off-by: Huacai Chen <huacai.chen@intel.com> Signed-off-by: Li Zhang <li.zhang@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Chen, Huacai
2008-Jun-06 02:18 UTC
RE: [Xen-devel] [patch]Fix a bug that can''t resume from S3 after createan HVM guest
This new patch may be better, just remove "__init" modifier of disable_pit_irq(). Signed-off-by: Huacai Chen <huacai.chen@intel.com> Signed-off-by: Li Zhang <li.zhang@intel.com> -----Original Message----- From: xen-devel-bounces@lists.xensource.com [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of Chen, Huacai Sent: 2008年6月6日 8:55 To: Keir Fraser Cc: xen-devel@lists.xensource.com Subject: [Xen-devel] [patch]Fix a bug that can''t resume from S3 after createan HVM guest Hi, Keir, If we don''t use PIT, we should disable it at boot time and at S3 resuming. In Xen this is done by disable_pit_irq(), but this function is used by __initcall(). After bootstrap it will be discarded and may be overwritten. This usually results in S3 resuming failure. This patch fixed the issue. Signed-off-by: Huacai Chen <huacai.chen@intel.com> Signed-off-by: Li Zhang <li.zhang@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel