Xen devel - May 2008 - [PATCH] Add xen_phys_start value in the crash info note

Hi,

This patch makes the vmcore utilities (ex. crash, makedumpfile) be
able to get the relocation address of the xen hypervisor from a vmcore. 
It is necessary for the utilities to find the data of the hypervisor 
structures.

Note that this patch does not raise any comptibility issue for the
utilities (which I know) nor the other components of xen.

Signed-off-by: Itsuro Oda <oda@valinux.co.jp>

diff -r f681c4de91fc xen/arch/x86/crash.c
--- a/xen/arch/x86/crash.c	Wed May 28 16:14:10 2008 +0100
+++ b/xen/arch/x86/crash.c	Fri May 30 08:40:50 2008 +0900
@@ -102,6 +102,7 @@ void machine_crash_shutdown(void)
     hvm_cpu_down();
 
     info = kexec_crash_save_info();
+    info->xen_phys_start = xen_phys_start;
     info->dom0_pfn_to_mfn_frame_list_list         
arch_get_pfn_to_mfn_frame_list_list(dom0);
 }
diff -r f681c4de91fc xen/include/xen/elfcore.h
--- a/xen/include/xen/elfcore.h	Wed May 28 16:14:10 2008 +0100
+++ b/xen/include/xen/elfcore.h	Fri May 30 08:39:40 2008 +0900
@@ -66,6 +66,7 @@ typedef struct {
     unsigned long xen_compile_time;
     unsigned long tainted;
 #if defined(__i386__) || defined(__x86_64__)
+    unsigned long xen_phys_start;
     unsigned long dom0_pfn_to_mfn_frame_list_list;
 #endif
 #if defined(__ia64__)

-- 
Itsuro ODA <oda@valinux.co.jp>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
> able to get the relocation address of the xen hypervisor from a vmcore.
> It is necessary for the utilities to find the data of the hypervisor
> structures.
> 
> Note that this patch does not raise any comptibility issue for the
> utilities (which I know) nor the other components of xen.
Since it both changes the size of the crash_info elf note, and adds the new
field in the middle of the crash_info structure, how can it not affect
compatibility?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Keir Fraser wrote:
> On 30/5/08 06:13, "Itsuro ODA" <oda@valinux.co.jp> wrote:
>
>   
>> This patch makes the vmcore utilities (ex. crash, makedumpfile) be
>> able to get the relocation address of the xen hypervisor from a vmcore.
>> It is necessary for the utilities to find the data of the hypervisor
>> structures.
>>
>> Note that this patch does not raise any comptibility issue for the
>> utilities (which I know) nor the other components of xen.
>>     
>
> Since it both changes the size of the crash_info elf note, and adds the new
> field in the middle of the crash_info structure, how can it not affect
> compatibility?
>
>  -- Keir
>   
Itsuro did it that way on purpose.  It maintains backwards compatibility by
keeping the dom0_pfn_to_mfn_frame_list_list field as the last field in the
PT_NOTE.  crash doesn''t know what a crash_xen_info_t structure is, but
only
its old and new size.

Dave



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel