This patch implements interrupt remapping for MSI/MSI-x. Signed-off-by: Weidong Han <weidong.han@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Isaku Yamahata
2008-May-30 02:31 UTC
[PATCH] compilation fix of iommu.h (was Re: [Xen-devel] [VTD] [PATCH 2/2] Interrupt remapping)
[IA64] compilation fix of iommu.h
Trivial compilation fix of iommu.h.
It includes asm/msi.h for struct msi_desc and struct msi_msg definition.
msi.h doesn''t exist yet on ia64 so declare struct msi_desc and
struct msi_msg in iommu.h and don''t include asm/msi.h.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
diff -r e5344a478af5 xen/include/xen/iommu.h
--- a/xen/include/xen/iommu.h Fri May 30 10:54:43 2008 +0900
+++ b/xen/include/xen/iommu.h Fri May 30 11:04:26 2008 +0900
@@ -26,7 +26,6 @@
#include <xen/pci.h>
#include <public/hvm/ioreq.h>
#include <public/domctl.h>
-#include <asm/msi.h>
extern int vtd_enabled;
extern int iommu_enabled;
@@ -78,6 +77,9 @@
unsigned int io_apic_read_remap_rte(unsigned int apic, unsigned int reg);
void io_apic_write_remap_rte(unsigned int apic,
unsigned int reg, unsigned int value);
+
+struct msi_desc;
+struct msi_msg;
void msi_msg_read_remap_rte(struct msi_desc *msi_desc, struct msi_msg *msg);
void msi_msg_write_remap_rte(struct msi_desc *msi_desc, struct msi_msg *msg);
struct qi_ctrl *iommu_qi_ctrl(struct iommu *iommu);
--
yamahata
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Hi, Weidong>This patch implements interrupt remapping for MSI/MSI-x. > >Signed-off-by: Weidong Han <weidong.han@intel.com>I got the following error at compiling the latest cset(17761). make[6]: Entering directory `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough/vtd'' gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing -stdgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after- statement -DNDEBUG -nostdinc -fno-builtin -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/root/unstable/xen-unstable. hg/xen/include -I/root/unstable/xen-unstable.hg/xen/include/asm-x86/mach -generic -I/root/unstable/xen-unstable.hg/xen/include/asm-x86/mach- default -msoft-float -fno-stack-protector -g -D__XEN__ -c intremap.c -o intremap.o cc1: warnings being treated as errors intremap.c: In function ''ioapic_rte_to_remap_entry'': intremap.c:143: error: overflow in implicit constant conversion make[6]: *** [intremap.o] Error 1 make[6]: Leaving directory `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough/vtd'' make[5]: *** [vtd/built_in.o] Error 2 make[5]: Leaving directory `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough'' make[4]: *** [passthrough/built_in.o] Error 2 make[4]: Leaving directory `/root/unstable/xen-unstable.hg/xen/drivers'' make[3]: *** [/root/unstable/xen-unstable.hg/xen/drivers/built_in.o] Error 2 make[3]: Leaving directory `/root/unstable/xen-unstable.hg/xen/arch/x86'' make[2]: *** [/root/unstable/xen-unstable.hg/xen/xen] Error 2 make[2]: Leaving directory `/root/unstable/xen-unstable.hg/xen'' make[1]: *** [install] Error 2 make[1]: Leaving directory `/root/unstable/xen-unstable.hg/xen'' make: *** [install-xen] Error 2 Is the attached patch correct? Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> Best Regards, Akio Takebe _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Hi Akio, Thank you for finding this issue. I worked out a patch based on yours. Randy (Weidong) Akio Takebe wrote:> Hi, Weidong > >> This patch implements interrupt remapping for MSI/MSI-x. >> >> Signed-off-by: Weidong Han <weidong.han@intel.com> > I got the following error at compiling the latest cset(17761). > > make[6]: Entering directory > `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough/vtd'' > gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing > -std= gnu99 -Wall -Wstrict-prototypes -Wno-unused-value > -Wdeclaration-after- statement -DNDEBUG -nostdinc -fno-builtin > -fno-common -iwithprefix include -Werror -Wno-pointer-arith -pipe > -I/root/unstable/xen-unstable. hg/xen/include > -I/root/unstable/xen-unstable.hg/xen/include/asm-x86/mach -generic > -I/root/unstable/xen-unstable.hg/xen/include/asm-x86/mach- default > -msoft-float -fno-stack-protector -g -D__XEN__ -c intremap.c -o > intremap.o > cc1: warnings being treated as errors > intremap.c: In function ''ioapic_rte_to_remap_entry'': > intremap.c:143: error: overflow in implicit constant conversion > make[6]: *** [intremap.o] Error 1 > make[6]: Leaving directory > `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough/vtd'' > make[5]: *** [vtd/built_in.o] Error 2 > make[5]: Leaving directory > `/root/unstable/xen-unstable.hg/xen/drivers/ passthrough'' > make[4]: *** [passthrough/built_in.o] Error 2 > make[4]: Leaving directory > `/root/unstable/xen-unstable.hg/xen/drivers'' make[3]: *** > [/root/unstable/xen-unstable.hg/xen/drivers/built_in.o] Error 2 > make[3]: Leaving directory > `/root/unstable/xen-unstable.hg/xen/arch/x86'' make[2]: *** > [/root/unstable/xen-unstable.hg/xen/xen] Error 2 > make[2]: Leaving directory `/root/unstable/xen-unstable.hg/xen'' > make[1]: *** [install] Error 2 > make[1]: Leaving directory `/root/unstable/xen-unstable.hg/xen'' > make: *** [install-xen] Error 2 > > > Is the attached patch correct? > > Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com> > > Best Regards, > > Akio Takebe_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel