Fix intel_iommu_unmap_page() Signed-off-by: Espen Skoglund <espen.skoglund@netronome.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Page table debug output improvements Signed-off-by: Espen Skoglund <espen.skoglund@netronome.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
+ if ( !root_present(root_entry[bus]) )
{
- printk("---- print_vtd_entries %d ----\n", i++);
+ unmap_vtd_domain_page(root_entry);
+ printk(" root_entry[%x] not present\n", bus);
+ return;
+ }
Why is the indentation not working? Are you using tabs instead of 4
spaces for indentation?
It''s good that you fixed print_vtd_entries(). I always wanted do that
but never got high enough in the priority.
Allen
>-----Original Message-----
>From: xen-devel-bounces@lists.xensource.com
>[mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of
>Espen Skoglund
>Sent: Monday, May 19, 2008 1:30 PM
>To: xen-devel@lists.xensource.com
>Subject: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
>
>Page table debug output improvements
>
>Signed-off-by: Espen Skoglund <espen.skoglund@netronome.com>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
>--- a/xen/arch/x86/domain.c Mon May 19 20:32:22 2008 +0100 >+++ b/xen/arch/x86/domain.c Mon May 19 20:42:54 2008 +0100 >@@ -127,12 +127,15 @@ > void dump_pageframe_info(struct domain *d) > { > struct page_info *page; >+ int cnt[8] = { 0, 0, 0, 0, 0, 0, 0, 0 }; > > printk("Memory pages belonging to domain %u:\n", d->domain_id); > > if ( d->tot_pages >= 10 ) > { > printk(" DomPage list too long to display\n"); >+ list_for_each_entry ( page, &d->page_list, list ) >+ cnt[(page->u.inuse.type_info >> 29) & 0x7]++; > } > else > { >@@ -141,8 +144,12 @@ > printk(" DomPage %p: caf=%08x, taf=%" PRtype_info "\n", > _p(page_to_mfn(page)), > page->count_info, page->u.inuse.type_info); >+ cnt[(page->u.inuse.type_info >> 29) & 0x7]++; > } > } >+ printk(" TypeCnt " >+ "{ none %d, L1 %d, L2 %d, L3 %d, L4 %d, seg %d, rw %d }\n", >+ cnt[0], cnt[1], cnt[2], cnt[3], cnt[4], cnt[5], cnt[7]); > > list_for_each_entry ( page, &d->xenpage_list, list ) > {Even if just used for debug output, I think using hard-coded numbers here is as unacceptable as it would be anywhere else. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Espen Skoglund
2008-May-20 10:34 UTC
RE: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
[Allen M Kay]> + if ( !root_present(root_entry[bus]) ) > { > - printk("---- print_vtd_entries %d ----\n", i++); > + unmap_vtd_domain_page(root_entry); > + printk(" root_entry[%x] not present\n", bus); > + return; > + }> Why is the indentation not working? Are you using tabs instead of 4 > spaces for indentation?Whoops. Yeah. It seems that the emacs local variables blob at the end of the file was missing. indent-tabs-mode was therefore set to true. eSk> It''s good that you fixed print_vtd_entries(). I always wanted do > that but never got high enough in the priority.> Allen>> -----Original Message----- >> From: xen-devel-bounces@lists.xensource.com >> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of >> Espen Skoglund >> Sent: Monday, May 19, 2008 1:30 PM >> To: xen-devel@lists.xensource.com >> Subject: [Xen-devel] [PATCH 1/5] VT-d support for PV guests >> >> Page table debug output improvements >> >> Signed-off-by: Espen Skoglund <espen.skoglund@netronome.com> >> >>_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel