This patch is related to Changeset 15635:7bdc9f6407d3 <http://xenbits.xensource.com/staging/xen-unstable.hg?rev/7bdc9f6407d3> [PVFB] Fix shift key for graphical vnc display. With above patch, if a user presses shift-insert, qemu sends shift down, shift up, insert down and then another shift key down (see trace below). This makes it impossible to do shift insert pasting or use guest hot shifted-Fkeys. Shift Insert trace: do_key_event():1135 keycode:2a shift down kbd_put_keycode():539 keycode:2a send shift down do_key_event():1135 keycode:d2 insert down kbd_put_keycode():539 keycode:aa send shift up kbd_put_keycode():539 keycode:e0 send insert down kbd_put_keycode():539 keycode:52 do_key_event():1135 keycode:d2 insert up kbd_put_keycode():539 keycode:e0 send insert up kbd_put_keycode():539 keycode:d2 kbd_put_keycode():539 keycode:2a send shift down do_key_event():1135 keycode:2a shift up kbd_put_keycode():539 keycode:aa send shift up Attached patch adds a check for the keycode being shiftable, something other than a keypad key, f1-12 , insert, del , etc. before allowing the press_shift_up() operation. Please apply to xen-unstable tip. Signed-off-by: Pat Campbell <plc@novell.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel