Get ACPI Px from dom0 and chose Px controller Add platform op hypercall case to get ACPI Px info from dom0. Chose Px controller from dom0 (cpufreq=dom0-kernel) or hypervisor (cpufreq=xen-cpufreq) Signed-off-by: Liu Jinsong <jinsong.liu@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Get ACPI Px from dom0 and chose Px controller > > Add platform op hypercall case to get ACPI Px info from dom0. > Chose Px controller from dom0 (cpufreq=dom0-kernel) > or hypervisor (cpufreq=xen-cpufreq)No gcc-specific attributes in the public header files. This means no __attribute__((packed)). Please fix that. Also why declare a local variable ''a'' in your changes to common/domain.c? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Thanks Keir, I will fix gcc-specific attributes in public header files ASAP. I add a local variable ''a'' in common/domain.c, since need to do '' xen_processor_pmbits &= (~a);'' If we directly use '' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)'' may result in some align issue if xen_processor_pmbits is not 32bits variable. So I add ''a'' with same type as ''xen_processor_pmbits''. Regards, Jinsong -----Original Message----- From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: Tuesday, May 13, 2008 4:56 PM To: Liu, Jinsong; xen-devel@lists.xensource.com Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Get ACPI Px from dom0 and chose Px controller > > Add platform op hypercall case to get ACPI Px info from dom0. > Chose Px controller from dom0 (cpufreq=dom0-kernel) > or hypervisor (cpufreq=xen-cpufreq)No gcc-specific attributes in the public header files. This means no __attribute__((packed)). Please fix that. Also why declare a local variable ''a'' in your changes to common/domain.c? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 13/5/08 10:34, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> I add a local variable ''a'' in common/domain.c, since need to do '' > xen_processor_pmbits &= (~a);'' > If we directly use '' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)'' may > result in some align issue if xen_processor_pmbits is not 32bits > variable. > So I add ''a'' with same type as ''xen_processor_pmbits''.If this is a concern then cast XEN_PROCESSOR_PM_PX before applying ~. Actually the right thing will happen without that since XEN_PROCESSOR_PM_PX is a signed constant, so when the bitwise-negated value is widened it will be sign extended. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yes, thanks a lot! I will change it ASAP. Regards, Jinsong -----Original Message----- From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: Tuesday, May 13, 2008 5:44 PM To: Liu, Jinsong; xen-devel@lists.xensource.com Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen On 13/5/08 10:34, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> I add a local variable ''a'' in common/domain.c, since need to do '' > xen_processor_pmbits &= (~a);'' > If we directly use '' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)''may> result in some align issue if xen_processor_pmbits is not 32bits > variable. > So I add ''a'' with same type as ''xen_processor_pmbits''.If this is a concern then cast XEN_PROCESSOR_PM_PX before applying ~. Actually the right thing will happen without that since XEN_PROCESSOR_PM_PX is a signed constant, so when the bitwise-negated value is widened it will be sign extended. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir, I''ve updated my patches accroding to your comments. [PATCH 2/5] [dom0] pm_dom0_1_px.patch: update public header files. [PATCH 3/5] [xen] pm_xen_1_hypercall.patch: update public header files, and common/domain.c Thanks, Jinsong -----Original Message----- From: Keir Fraser [mailto:keir.fraser@eu.citrix.com] Sent: Tuesday, May 13, 2008 4:56 PM To: Liu, Jinsong; xen-devel@lists.xensource.com Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@intel.com> wrote:> Get ACPI Px from dom0 and chose Px controller > > Add platform op hypercall case to get ACPI Px info from dom0. > Chose Px controller from dom0 (cpufreq=dom0-kernel) > or hypervisor (cpufreq=xen-cpufreq)No gcc-specific attributes in the public header files. This means no __attribute__((packed)). Please fix that. Also why declare a local variable ''a'' in your changes to common/domain.c? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel