Hi, If we define wrong values to a disk parameter in domain configuration files, we get an error message or a guest OS panic. 1. If we define a wrong disk type, xm create command error occurs about 100 seconds later. e.g. disk=[''xyz:/xen/root-vm1.img,hda1,w''] 2. If we forget a disk type, a guest OS panic occurs. e.g. disk=[''/xen/root-vm1.img,hda1,w''] This patch adds syntax checks of disk types. Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> Best regards, Kan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yosuke Iwamatsu
2008-May-13 10:33 UTC
Re: [Xen-devel] [PATCH] Add syntax check for block devices
Hi, I cannnot boot a guest with disks of ''tap'' type specified in the config file since cs 17617, unfortunately :-( Attached patch would fix the issue. Thanks, -- Yosuke Masaki Kanno wrote:> Hi, > > If we define wrong values to a disk parameter in domain configuration > files, we get an error message or a guest OS panic. > > 1. If we define a wrong disk type, xm create command error occurs > about 100 seconds later. > e.g. disk=[''xyz:/xen/root-vm1.img,hda1,w''] > > 2. If we forget a disk type, a guest OS panic occurs. > e.g. disk=[''/xen/root-vm1.img,hda1,w''] > > This patch adds syntax checks of disk types. > > > Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> > > Best regards, > Kan > > > > ------------------------------------------------------------------------ > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Masaki Kanno
2008-May-14 00:00 UTC
Re: [Xen-devel] [PATCH] Add syntax check for block devices
Tue, 13 May 2008 19:33:08 +0900, Yosuke Iwamatsu wrote:>Hi, > >I cannnot boot a guest with disks of ''tap'' type specified >in the config file since cs 17617, unfortunately :-( >Attached patch would fix the issue. > >Thanks, > -- YosukeOops! Thank you, Yosuke. Best regards, Kan> >Masaki Kanno wrote: >> Hi, >> >> If we define wrong values to a disk parameter in domain configuration >> files, we get an error message or a guest OS panic. >> >> 1. If we define a wrong disk type, xm create command error occurs >> about 100 seconds later. >> e.g. disk=[''xyz:/xen/root-vm1.img,hda1,w''] >> >> 2. If we forget a disk type, a guest OS panic occurs. >> e.g. disk=[''/xen/root-vm1.img,hda1,w''] >> >> This patch adds syntax checks of disk types. >> >> >> Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com> >> >> Best regards, >> Kan >> >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel > > >-------------------------------text/plain------------------------------- >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel