Xen devel - May 2008 - [PATCH] ioemu: pump SDL events on resize

ioemu: pump SDL events on resize

When sdl_resize resizes the SDL window, some window manager send back
a ConfigureNotify event, which triggers a SDL_VIDEORESIZE event. That
event, however, is seen only much later, on the next VGA refresh
round. If the guest quickly switches to another resolution in between,
the SDL_VIDEORESIZE event makes us erroneously rescale that new
resolution into the old one.

This patch makes us pump that window manager event, so that no
SDL_VIDEORESIZE event is generated.

Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

diff -r 7190027c2da8 tools/ioemu/sdl.c
--- a/tools/ioemu/sdl.c	Thu May 01 18:56:04 2008 +0100
+++ b/tools/ioemu/sdl.c	Fri May 02 10:38:33 2008 +0100
@@ -294,6 +294,9 @@ static void sdl_resize(DisplayState *ds,
         };
 #endif
     }
+
+    /* Process any WM-generated resize event */
+    SDL_PumpEvents();
 }
 
 static void sdl_colourdepth(DisplayState *ds, int depth)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Samuel Thibault, le Fri 02 May 2008 11:21:33 +0100, a écrit
:
> ioemu: pump SDL events on resize
> 
> When sdl_resize resizes the SDL window, some window manager send back
> a ConfigureNotify event, which triggers a SDL_VIDEORESIZE event. That
> event, however, is seen only much later, on the next VGA refresh
> round. If the guest quickly switches to another resolution in between,
> the SDL_VIDEORESIZE event makes us erroneously rescale that new
> resolution into the old one.
> 
> This patch makes us pump that window manager event, so that no
> SDL_VIDEORESIZE event is generated.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
Oops, I sent an old patch, here is a proper one:

diff -r 7190027c2da8 tools/ioemu/sdl.c
--- a/tools/ioemu/sdl.c	Thu May 01 18:56:04 2008 +0100
+++ b/tools/ioemu/sdl.c	Fri May 02 10:47:36 2008 +0100
@@ -235,6 +235,9 @@ static void sdl_resize(DisplayState *ds,
 
  again:
     screen = SDL_SetVideoMode(w, h, 0, flags);
+
+    /* Process any WM-generated resize event */
+    SDL_PumpEvents();
 
     if (!screen) {
         fprintf(stderr, "Could not open SDL display: %s\n",
SDL_GetError());

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel