This changeset:
changeset: 15606:17820aa1b2c0
user: Keir Fraser <keir.fraser@citrix.com>
date: Fri Dec 14 11:58:37 2007 +0000
summary: hvm: Remove duplicate assignment of __HYPERVISOR_grant_table_op in
Has broken our HVM PV drivers. Previously we were using:
520 if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) != 0)
||
521 (pset->status != 0)) {
even on HVM. Now, this isn''t actually necessary (stuff works fine with
the call nop''d out, presumably due to the auto-sizing), but I wonder
why the
only grant op allowed is _query_size? IE what''s the status of grant
table code on HVM/PV? Is it just disabled because no compat audit has
been done, or what?
regards
john
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On 28/3/08 16:50, "John Levon" <levon@movementarian.org> wrote:> Has broken our HVM PV drivers. Previously we were using: > > 520 if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) !> 0) || > 521 (pset->status != 0)) { > > even on HVM. Now, this isn''t actually necessary (stuff works fine with > the call nop''d out, presumably due to the auto-sizing), but I wonder why the > only grant op allowed is _query_size? IE what''s the status of grant > table code on HVM/PV? Is it just disabled because no compat audit has > been done, or what?Most of the mapping calls wouldn''t work at all. Query_size() could probably be simply given a stub implementation for HVM that returns all is good. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Mar 28, 2008 at 05:03:17PM +0000, Keir Fraser wrote:> > Has broken our HVM PV drivers. Previously we were using: > > > > 520 if ((HYPERVISOR_grant_table_op(GNTTABOP_setup_table, pset, 1) !> > 0) || > > 521 (pset->status != 0)) { > > > > even on HVM. Now, this isn''t actually necessary (stuff works fine with > > the call nop''d out, presumably due to the auto-sizing), but I wonder why the > > only grant op allowed is _query_size? IE what''s the status of grant > > table code on HVM/PV? Is it just disabled because no compat audit has > > been done, or what? > > Most of the mapping calls wouldn''t work at all.OK. I think we were effectively ending up with a call that did nothing but did it quietly and now we''re getting back (the correct) ENOSYS. Clearly our bug but it wasn''t quite obvious what was supposed to work.> Query_size() could probably be simply given a stub implementation for > HVM that returns all is good.It already is, I think? regards john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 28/3/08 17:07, "John Levon" <levon@movementarian.org> wrote:>> Most of the mapping calls wouldn''t work at all. > > OK. I think we were effectively ending up with a call that did nothing > but did it quietly and now we''re getting back (the correct) ENOSYS. > Clearly our bug but it wasn''t quite obvious what was supposed to work. > >> Query_size() could probably be simply given a stub implementation for >> HVM that returns all is good. > > It already is, I think?Sorry, typo. I meant setup_table(). And actually I think we can just let that one through just as we already do for query_size(). I''ll make that fix and put it in the 3.2 and 3.1 branches. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Fri, Mar 28, 2008 at 05:45:17PM +0000, Keir Fraser wrote:> >> Query_size() could probably be simply given a stub implementation for > >> HVM that returns all is good. > > > > It already is, I think? > > Sorry, typo. I meant setup_table(). And actually I think we can just let > that one through just as we already do for query_size().I''ve confirmed this fixes the problem (via the 3.1 staging tree) thanks john _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel