Samuel Thibault
2008-Mar-21 10:03 UTC
[Xen-devel] Re: [Xen-bugs] [Bug 1194] both Linux and Windows hvm guest can not boot up
bugzilla-daemon@lists.xensource.com, le Thu 20 Mar 2008 23:23:35 -0700, a écrit :> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1194 > > ------- Comment #3 from haicheng.li@intel.com 2008-03-20 23:23 ------- > This bug may be related to c/s #17266 which says that IDE should accept SETMUL > 0 as upstream qemu now does. It is following: > > --- a/tools/ioemu/hw/ide.c Thu Mar 20 17:45:00 2008 +0000 > +++ b/tools/ioemu/hw/ide.c Thu Mar 20 17:47:05 2008 +0000 > @@ -1823,7 +1823,6 @@ static void ide_ioport_write(void *opaqu > break; > case WIN_SETMULT: > if (s->nsector > MAX_MULT_SECTORS || > - s->nsector == 0 || > (s->nsector & (s->nsector - 1)) != 0) { > ide_abort_command(s); > } else { > > If revert c/s 17266, WinXP guest can boot up, but Linux still can''t.Oh, that''s pretty odd that it doesn''t like it... Well then OK, please revert it (it was mostly meant to fix a scary but harmless warning in the Linux hda initialization). I''m also getting the Linux hda issue, maybe I''ll try to dig it out. Samuel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Keir Fraser
2008-Mar-21 10:10 UTC
Re: [Xen-devel] Re: [Xen-bugs] [Bug 1194] both Linux and Windows hvm guest can not boot up
On 21/3/08 10:03, "Samuel Thibault" <samuel.thibault@eu.citrix.com> wrote:>> --- a/tools/ioemu/hw/ide.c Thu Mar 20 17:45:00 2008 +0000 >> +++ b/tools/ioemu/hw/ide.c Thu Mar 20 17:47:05 2008 +0000 >> @@ -1823,7 +1823,6 @@ static void ide_ioport_write(void *opaqu >> break; >> case WIN_SETMULT: >> if (s->nsector > MAX_MULT_SECTORS || >> - s->nsector == 0 || >> (s->nsector & (s->nsector - 1)) != 0) { >> ide_abort_command(s); >> } else { >> >> If revert c/s 17266, WinXP guest can boot up, but Linux still can''t. > > Oh, that''s pretty odd that it doesn''t like it... Well then OK, please > revert it (it was mostly meant to fix a scary but harmless warning in > the Linux hda initialization). I''m also getting the Linux hda issue, > maybe I''ll try to dig it out.This patch has been found blameless. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel