Instead of arbitrarily calling gnttab_suspend(), {gnttab,irq,time}_resume()
from the resume path in drivers/xen/core/machine_reboot.c, wouldn''t be
more reasonable to do a more complete suspend/resume operation by
calling sysdev_{suspend,resume} (and, I didn''t check whether this is
already done for all of them, setting up the necessary sys_device/
sysdev_class instances so everything gets called as needed)?
Thanks, Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Can we constrain the ordering then? I think it does matter (would have to double check exactly what the req''d constraints are though). -- Keir On 13/3/08 15:45, "Jan Beulich" <jbeulich@novell.com> wrote:> Instead of arbitrarily calling gnttab_suspend(), {gnttab,irq,time}_resume() > from the resume path in drivers/xen/core/machine_reboot.c, wouldn''t be > more reasonable to do a more complete suspend/resume operation by > calling sysdev_{suspend,resume} (and, I didn''t check whether this is > already done for all of them, setting up the necessary sys_device/ > sysdev_class instances so everything gets called as needed)? > > Thanks, Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
There ought to be ways, since I''m sure native suspend/resume is depending on some sort of ordering, too. Perhaps through using the right kind of initcall for registering the respective sysdev_class? Jan>>> Keir Fraser <keir.fraser@eu.citrix.com> 13.03.08 16:52 >>>Can we constrain the ordering then? I think it does matter (would have to double check exactly what the req''d constraints are though). -- Keir On 13/3/08 15:45, "Jan Beulich" <jbeulich@novell.com> wrote:> Instead of arbitrarily calling gnttab_suspend(), {gnttab,irq,time}_resume() > from the resume path in drivers/xen/core/machine_reboot.c, wouldn''t be > more reasonable to do a more complete suspend/resume operation by > calling sysdev_{suspend,resume} (and, I didn''t check whether this is > already done for all of them, setting up the necessary sys_device/ > sysdev_class instances so everything gets called as needed)? > > Thanks, Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel