Xen devel - Feb 2008 - [amd iommu] [patch 1/2]Add APCI table support for AMD IOMMU

Signed-off-by: Wei Wang <wei.wang2@amd.com>

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Some comments below.

+
+void __init dump_acpi_table_header(struct acpi_table_header *table)

I think this can be static?

Throughout this file you''ve used slightly Linux-y coding style.  Is
this
intentional?  In particular, the brackets around if expressions aren''t
spaced
out from the expression as they usually are under Xen and in one place
you''ve
missed a newline before a {.  If you''re trying to keep the coding style
in
sync to minimise the diff with upstream sources then I think that''s
quite
reasonable (although I think we usually keep tabbed indenting if importing 
from upstream Linux).

Keir will probably let you know if he thinks the formatting is important or 
check the code in otherwise, so don''t let me worry you too much!

Other than these few comments, your code largely made my patch checking suite 
happy, so nice work ;-)

Cheers,
Mark

-- 
Push Me Pull You - Distributed SCM tool (http://www.cl.cam.ac.uk/~maw48/pmpu/)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel