Hi Keir, Changeset 17104 does not look correct to me. svm_set_interrupt_shadow() seems to be a copy & paste bug, because the intr_shadow parameter is unused. I think, what you intended to do is the attached patch. That''s all what I found so far just from reading the diff - but there may be more. Please double-check. Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> -- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Nice one. I didn''t have a good coding afternoon on Friday. :-( In general the mmio (and other) emulation changes have had very little testing on AMD, so please do test and let me know if anything else has broken. -- Keir On 25/2/08 08:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> > Hi Keir, > > Changeset 17104 does not look correct to me. > svm_set_interrupt_shadow() seems to be a copy & paste bug, because > the intr_shadow parameter is unused. > I think, what you intended to do is the attached patch. > That''s all what I found so far just from reading the diff - but there may be > more. Please double-check. > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Monday 25 February 2008 10:03:18 Keir Fraser wrote:> Nice one. I didn''t have a good coding afternoon on Friday. :-( > > In general the mmio (and other) emulation changes have had very little > testing on AMD, so please do test and let me know if anything else has > broken.Yes, there are MMIO problems. We tracked them down to changeset 17090. Christoph> > -- Keir > > On 25/2/08 08:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote: > > Hi Keir, > > > > Changeset 17104 does not look correct to me. > > svm_set_interrupt_shadow() seems to be a copy & paste bug, because > > the intr_shadow parameter is unused. > > I think, what you intended to do is the attached patch. > > That''s all what I found so far just from reading the diff - but there may > > be more. Please double-check. > > > > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Yes, Intel''s most recently mentioned bug (1180: low-res and low-colour WinXP display) is also due to the mmio changes. At least it goes away when I revert changesets 17105, 17104, 17102, 17100, 17098, 17090, in that order. -- Keir On 28/2/08 16:12, "Christoph Egger" <Christoph.Egger@amd.com> wrote:> On Monday 25 February 2008 10:03:18 Keir Fraser wrote: >> Nice one. I didn''t have a good coding afternoon on Friday. :-( >> >> In general the mmio (and other) emulation changes have had very little >> testing on AMD, so please do test and let me know if anything else has >> broken. > > Yes, there are MMIO problems. We tracked them down to changeset 17090. > > Christoph > > >> >> -- Keir >> >> On 25/2/08 08:22, "Christoph Egger" <Christoph.Egger@amd.com> wrote: >>> Hi Keir, >>> >>> Changeset 17104 does not look correct to me. >>> svm_set_interrupt_shadow() seems to be a copy & paste bug, because >>> the intr_shadow parameter is unused. >>> I think, what you intended to do is the attached patch. >>> That''s all what I found so far just from reading the diff - but there may >>> be more. Please double-check. >>> >>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com> > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel