# HG changeset patch
# User xen-discuss@opensolaris.org
# Date 1203680243 28800
# Node ID 3a0e7fc8b4b7c650c9377c7b2a197c127913a622
# Parent 0accc274f62715d356a591d2286027f7591a9412
Fix ioemu compile on Solaris
_POSIX_C_SOURCE does not guarantee the available of the 1003.1j option
which contains posix_memalign(). Fix the test to explicitly test for
Linux.
Signed-off-by: John Levon <john.levon@sun.com>
diff --git a/tools/ioemu/osdep.c b/tools/ioemu/osdep.c
--- a/tools/ioemu/osdep.c
+++ b/tools/ioemu/osdep.c
@@ -178,7 +178,7 @@ void kqemu_vfree(void *ptr)
void *qemu_memalign(size_t alignment, size_t size)
{
-#if defined(_POSIX_C_SOURCE)
+#if defined(__Linux__)
int ret;
void *ptr;
ret = posix_memalign(&ptr, alignment, size);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
Christoph Egger
2008-Feb-25 08:00 UTC
Re: [Xen-devel] [PATCH] Fix ioemu compile on Solaris
On Friday 22 February 2008 14:05:00 john.levon@sun.com wrote:> # HG changeset patch > # User xen-discuss@opensolaris.org > # Date 1203680243 28800 > # Node ID 3a0e7fc8b4b7c650c9377c7b2a197c127913a622 > # Parent 0accc274f62715d356a591d2286027f7591a9412 > Fix ioemu compile on Solaris > > _POSIX_C_SOURCE does not guarantee the available of the 1003.1j option > which contains posix_memalign(). Fix the test to explicitly test for > Linux. > > Signed-off-by: John Levon <john.levon@sun.com> > > diff --git a/tools/ioemu/osdep.c b/tools/ioemu/osdep.c > --- a/tools/ioemu/osdep.c > +++ b/tools/ioemu/osdep.c > @@ -178,7 +178,7 @@ void kqemu_vfree(void *ptr) > > void *qemu_memalign(size_t alignment, size_t size) > { > -#if defined(_POSIX_C_SOURCE) > +#if defined(__Linux__)That''s wrong. NetBSD also has posix_memalign(). Maybe this: #ifndef __sun__> int ret; > void *ptr; > ret = posix_memalign(&ptr, alignment, size); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel-- AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Geschäftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplementär: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Geschäftsführer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On 25/2/08 08:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:>> -#if defined(_POSIX_C_SOURCE) >> +#if defined(__Linux__) > > That''s wrong. NetBSD also has posix_memalign(). > Maybe this: > > #ifndef __sun__I shall opt for defined(_POSIX_C_SOURCE) && !defined(__sun__) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel